Bug 351493 - [N-TRIG] Stylus buttons do not respond with wintab driver.
Summary: [N-TRIG] Stylus buttons do not respond with wintab driver.
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Tablets (tablet issues are only very rarely bugs in Krita!) (show other bugs)
Version: 2.9.6
Platform: Compiled Sources Microsoft Windows
: NOR major
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-19 17:59 UTC by maaltan
Modified: 2016-03-16 07:51 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description maaltan 2015-08-19 17:59:54 UTC
Sorry if this is a dupe, I saw some bugs that were similar but didn't directly address this specific issue.

I am using a surface pro 3 with windows 8.1 (still waiting for 10).  This is the model that switched to the n-trig based stylus. the behavior detailed below is the same for 64 bit and 32 bit builds of krita

The problem is the "right click" button (upper button on side) no longer opens the pallet once the wintab driver (1.0.0.18-64 bit.. the only one i can still find online) is installed.     The little white right click circle (drawn by windows) appears normally but nothing happens.  

Also the lower side button very rarely switches to eraser mode for a half stroke or so. Without the wintab driver it appeared to do nothing, but i also didn't try it very long.

The "hold right click" functionalty  (where windows draws the circle slowly and when full and released it generates right click) when performed with the pen works for the dockables but not on the canvas.  Oddly enough if I use my finger for the hold right click it DOES open the pallet.



Reproducible: Always

Steps to Reproduce:
1.install krita and note right click (upper side button) works on the ntrig stylus but pressure sensitivity does not
2. install wintab
3. pressure sensitivity now works (see note about vscp100 libs above) but the right click button does not.

Actual Results:  
Nothing.

Expected Results:  
pallet to appear

---------------------------------

Unrelated:  I discovered why pressure sensitivity does not work for the 64 bit build on the surface.   windows 8 does not ship with the visual studio c++ 2010 redistributable libraries (at least for 64 bit) and neither does wintab.  These must be installed manually.  

When i installed Gimp, I received a clear popup error saying that it couldn't find these libraries. once i fixed gimp,  krita 64b started working as well.

I am guessing the exception is being trapped by the krita code and discarded?  Perhaps it would be better to allow the popup message to occur?
Comment 1 Halla Rempt 2015-08-19 18:22:41 UTC
Hi, 

Weird, we shouldn't need the msvc2010 redistributables, since Krita is built with msvc 2012! But I can add them to the install, if the wintab libary needs them...

Support for the eraser buttons in as far as is possible, was added July 30. There are no builds yet, since I messed up my build environment and have to recreate it (unless it's something else that broke loading/saving .kra files on windows...)

commit 8570f238078c4a14789edb64d3558f3253c27553
Author: Michael Abrahams <miabraha@gmail.com>
Date:   Thu Jul 30 05:36:27 2015 -0400

    Workaround for Surface Pro 3 Eraser
    
    This patch rewrites most of kis_tablet_support_win.cpp to support basic
    use of the eraser key on the Surface Pro 3. The keyissue is that the
    SP3 eraser button does not register being held until the stylus is
    touched to the screen. It generates a series of false stylus button
    presses.
    
    This patch attempts to handle those issues by watching for "inline"
    cursor changes. If a packet pops up with a different cursor ID, we will
    dispatch a release event and a tool switch signal. This breaks some
    layers of abstraction but it seems to work.
    
    Differential: https://phabricator.kde.org/D146
    BUG: 341899
Comment 2 Marcus Kjeldsen 2015-09-25 21:26:51 UTC
I can confirm :) Right click palette is sorely missed when wintab is installed.

Eraser seems to work well for me now, though.
Comment 3 Halla Rempt 2016-03-16 07:51:15 UTC
I think this is as good as we can make it...