Bug 351455 - Modules shall not be soversioned
Summary: Modules shall not be soversioned
Status: RESOLVED FIXED
Alias: None
Product: KBibTeX
Classification: Applications
Component: Compiling/packaging (show other bugs)
Version: 0.6
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Thomas Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-18 19:29 UTC by Christophe Marin
Modified: 2016-02-01 21:33 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 0.6.1


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christophe Marin 2015-08-18 19:29:53 UTC
Noticed while reviewing the openSUSE package update.

Commits ed811598 and 4a52e703 add soversions for the kbibtexpart module. This part of these commits shall be reverted. Modules don't need (and never have) symlinks.
Comment 1 Thomas Fischer 2015-08-18 20:48:14 UTC
Git commit cedcb72a6d56ea214e3f5a6c7f4f231a023e474e by Thomas Fischer.
Committed on 18/08/2015 at 20:40.
Pushed by thomasfischer into branch 'kbibtex/0.6'.

Removing soversion from KBibTeX Part

As noticed by Christophe Giboudeaux when reviewing packages
for openSUSE, KBibTeX had soversions for its KPart modules.
This is not seen for other KParts and therefore version
numbers get removed from KBibTeX's KPart.

M  +0    -9    src/parts/CMakeLists.txt

http://commits.kde.org/kbibtex/cedcb72a6d56ea214e3f5a6c7f4f231a023e474e
Comment 2 Thomas Fischer 2015-08-18 20:48:36 UTC
Git commit fb0518d477cd0836945fb94c903b6dcab017bb17 by Thomas Fischer.
Committed on 18/08/2015 at 20:42.
Pushed by thomasfischer into branch 'kbibtex/0.7'.

Removing soversion from KBibTeX Part

As noticed by Christophe Giboudeaux when reviewing packages
for openSUSE, KBibTeX had soversions for its KPart modules.
This is not seen for other KParts and therefore version
numbers get removed from KBibTeX's KPart.

M  +0    -9    src/parts/CMakeLists.txt

http://commits.kde.org/kbibtex/fb0518d477cd0836945fb94c903b6dcab017bb17
Comment 3 Thomas Fischer 2015-08-18 20:49:43 UTC
Git commit ec0c94ff5d963be7d4beefe0f3ae414fc8f729b3 by Thomas Fischer.
Committed on 18/08/2015 at 20:44.
Pushed by thomasfischer into branch 'master'.

Removing soversion from KBibTeX Part

As noticed by Christophe Giboudeaux when reviewing packages
for openSUSE, KBibTeX had soversions for its KPart modules.
This is not seen for other KParts and therefore version
numbers get removed from KBibTeX's KPart.

Manual forward-port of commit fb0518d.

M  +0    -9    src/parts/CMakeLists.txt

http://commits.kde.org/kbibtex/ec0c94ff5d963be7d4beefe0f3ae414fc8f729b3
Comment 4 Thomas Fischer 2015-08-18 20:55:34 UTC
I made changes to all relevant branches. Please check and confirm that those commits solve the probem.

Do you deem this issue sufficiently severe that a 0.6.1 release is necessary?
Comment 5 Christophe Marin 2015-08-19 07:57:05 UTC
(In reply to Thomas Fischer from comment #4)
> I made changes to all relevant branches. Please check and confirm that those
> commits solve the probem.
> 
> Do you deem this issue sufficiently severe that a 0.6.1 release is necessary?

It's up to you :) Notifying release-team@ may be enough with the patch attached is probably enough for now.
Comment 6 Thomas Fischer 2016-02-01 21:33:05 UTC
(In reply to Christophe Giboudeaux from comment #5)
> It's up to you :) Notifying release-team@ may be enough with the patch
> attached is probably enough for now.
KBibTeX being ExtraGear is independent from official KDE releases. I am planning a bugfix release for 0.6 'really soon' (TM), which should resolve this matter.