Bug 351435 - Transform mask always recalculating twice after apllying liquify transformations
Summary: Transform mask always recalculating twice after apllying liquify transformations
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Tools/Transform (other bugs)
Version First Reported In: git master (please specify the git hash!)
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-18 12:22 UTC by sghpunk
Modified: 2016-04-14 15:55 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description sghpunk 2015-08-18 12:22:33 UTC
Second time recalculation begins after 1-2sec after applying.

Reproducible: Always

Steps to Reproduce:
1. Open or create image with size ~4000x3000px (8bit sRGB)
2. Add transform mask to layer
3. Do some transformations (Liquify) on just added transform mask
4. Apply transformations.
5. See transform mask recalculating twice after appliyng transformations.

Actual Results:  
Transform mask always recalculating twice after apllying liquify transformations

Expected Results:  
Transform mask must recalculating once after apllying liquify transformations
Comment 1 Halla Rempt 2015-08-18 12:26:16 UTC
I do see the image being recomposed twice, also after, for instance hiding then unhiding the mask, so I can confirm the issue.
Comment 2 Dmitry Kazakov 2016-04-14 15:55:33 UTC
Git commit 0d2747e8fbfc0e352b1b0d8af63280d3eab5671e by Dmitry Kazakov.
Committed on 14/04/2016 at 15:53.
Pushed by dkazakov into branch 'master'.

Don't double update the transformation mask when applying transform

setDirty() initiates the static image regeneration as well, so we should
skip it whenever it is possible, that is when when the mask is not hidden
(in the latter case we should clear the layer's projection, therefore
a full update with mask being FILTHY node is needed)
Ref T2081

M  +26   -18   plugins/tools/tool_transform2/strokes/transform_stroke_strategy.cpp

http://commits.kde.org/krita/0d2747e8fbfc0e352b1b0d8af63280d3eab5671e