Bug 351241 - Table view shows wrong thumbnails [patch]
Summary: Table view shows wrong thumbnails [patch]
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Albums-TableView (show other bugs)
Version: 4.12.0
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-13 09:08 UTC by DrSlony
Modified: 2015-08-20 21:04 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.13.0
Sentry Crash Report:


Attachments
tableview.png (204.49 KB, image/png)
2015-08-19 06:10 UTC, Maik Qualmann
Details
tableviewthumbs.patch (1.99 KB, patch)
2015-08-20 18:22 UTC, Maik Qualmann
Details
tableviewthumbs2.patch (2.12 KB, patch)
2015-08-20 18:42 UTC, Maik Qualmann
Details

Note You need to log in before you can comment on or make changes to this bug.
Description DrSlony 2015-08-13 09:08:08 UTC
Thumbnails when in table view mode are chopped into squares. Why?! Now I can't tell landscape from portrait.

Reproducible: Always
Comment 1 caulier.gilles 2015-08-17 09:33:32 UTC
Maik,

I identified where the problem is with this file :

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/app/views/tableview/tableview_column_thumbnail.cpp#L121

Look like only landscape image sizes are supported, not portrait. Fix will be easy to do i think...

Gilles
Comment 2 Maik Qualmann 2015-08-19 06:10:56 UTC
Created attachment 94109 [details]
tableview.png

I have not yet looked into the source code. But I see no error in the representation of landscape or portrait photos. See the screenshot.

Maik
Comment 3 DrSlony 2015-08-19 07:07:23 UTC
4.12.0 http://i.imgur.com/k2oo0ka.png
Comment 4 caulier.gilles 2015-08-19 08:59:59 UTC
Maik,

To reproduce the problem, play with thumbnail column size of table view and change thumbnail size with status-bar slider. I can reproduce the problem described by DrSlony.

Note : create an album with portrait AND landscape images.

Gilles
Comment 5 Maik Qualmann 2015-08-20 18:22:27 UTC
Created attachment 94137 [details]
tableviewthumbs.patch

Gilles, please test this patch.

Maik
Comment 6 caulier.gilles 2015-08-20 18:31:05 UTC
Excelent. With this patch, digiKam work like a charm now... Congratulations...

Gilles
Comment 7 Maik Qualmann 2015-08-20 18:42:38 UTC
Created attachment 94139 [details]
tableviewthumbs2.patch

Only small code optimization.

Maik
Comment 8 Maik Qualmann 2015-08-20 18:53:32 UTC
Git commit 523b4baf62a354c06086d8825940964efaea0c55 by Maik Qualmann.
Committed on 20/08/2015 at 18:46.
Pushed by mqualmann into branch 'master'.

apply patch #94139 to correct thumbnails scale in the table view
FIXED-IN: 4.13.0

M  +2    -1    NEWS
M  +6    -12   app/views/tableview/tableview_column_thumbnail.cpp

http://commits.kde.org/digikam/523b4baf62a354c06086d8825940964efaea0c55
Comment 9 caulier.gilles 2015-08-20 20:35:27 UTC
Git commit 3084138b072cd51acb27edd4a70aedbeba0ffd9f by Gilles Caulier.
Committed on 20/08/2015 at 20:34.
Pushed by cgilles into branch 'frameworks'.

apply patch #523b4baf62a354c06086d8825940964efaea0c55 from git/master to frameworks branch

M  +8    -13   app/views/tableview/tableview_column_thumbnail.cpp

http://commits.kde.org/digikam/3084138b072cd51acb27edd4a70aedbeba0ffd9f