Bug 351037 - m_clientSideDecorated is "invalidly" false since gtk no longer adds _GTK_FRAME_EXTENTS
Summary: m_clientSideDecorated is "invalidly" false since gtk no longer adds _GTK_FRAM...
Status: RESOLVED WORKSFORME
Alias: None
Product: kwin
Classification: Plasma
Component: core (show other bugs)
Version: 5.3.2
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
: 352960 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-08-06 15:51 UTC by Markus Heß
Modified: 2023-01-18 13:15 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Output of xprop (6.42 KB, text/plain)
2015-08-07 08:09 UTC, Markus Heß
Details
Output of xwininfo (720 bytes, text/plain)
2015-08-07 08:09 UTC, Markus Heß
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Heß 2015-08-06 15:51:10 UTC
After enabling the script "Enforces Window Decorations on GTK+ window", I would expect that the KDE window decorations are painted around a GTK3 window. Unfortunately, GTK3 windows are still painted without the window decoration. Therefore it is also not possible to use the window features which are provided by KWin (e.g. Always On Top).

Reproducible: Always

Steps to Reproduce:
1. Enable the KWin script "Enforces Window Decorations on GTK+ window"
2. Start a GTK3 application


Actual Results:  
The application start without any window decoration.

Expected Results:  
The application should start with a window decoration.
Comment 1 Thomas Lübking 2015-08-06 16:19:09 UTC
please attach the outputs of "xprop" and "xwininfo" on such window and also record your gtk3 version
Comment 2 Markus Heß 2015-08-07 08:09:15 UTC
Created attachment 93925 [details]
Output of xprop
Comment 3 Markus Heß 2015-08-07 08:09:51 UTC
Created attachment 93926 [details]
Output of xwininfo
Comment 4 Markus Heß 2015-08-07 08:11:40 UTC
The gtk version is 3.16.6
Comment 5 Thomas Lübking 2015-08-07 08:28:11 UTC
There's no _GTK_FRAME_EXTENTS

@Martin
I recall http://kwin.kde.narkive.com/lXfptMeL/gtk3-double-decorations but somehow also that they had reverted that change, yesno?
Comment 6 Martin Flöser 2015-08-10 08:36:25 UTC
I'm not aware of any changes on GTK side on that. On the one hand it's good if they don't add _GTK_FRAME_EXTENTS any more given that non-Mutter WMs cannot handle that hint. On the other side this makes it impossible for us to provide the required integration for GTK windows in Plasma.

@Markus: Could you please raise a bug on the GTK bug tracker that it's not possible to disable the CSD on non-GNOME environments?
Comment 7 Markus Heß 2015-08-10 10:46:29 UTC
I filed a new bug report: https://bugzilla.gnome.org/show_bug.cgi?id=753445
Comment 8 Thomas Lübking 2015-08-10 18:40:23 UTC
Gtk wants it announced in _NET_SUPPORTED, but we do not support this at all (and will then likely get the client side shadows)

They suggest to check for a gtk client by interpreting the gtk properties (like _GTK_APPLICATION_ID) but that doesn't cut it, because a gtk(2) client may be validly undecorated (eg. audacious/xmms)

Stupid question:
even with the script working, you simply got 2 titlebars, right? (gtk3 does not turn off their CSD, for if they would, the absence of _GTK_FRAME_EXTENTS in _NET_SUPPORTED would be a perfect opportunity)
Comment 9 Markus Heß 2015-08-11 08:15:37 UTC
Yes, I got 2 titlebars before, but I was able to control the window behavior (Always on top, etc.). Besides the visual integration, at least such usability features should be available.

The usage of the Activities is also broken. GTK3 windows are always visible on each Activity. I think this is also related to the missing window decoration or am I wrong?

As far as I understand, the best solution would be if they give the possibility to disable the CSD right? If this is the case, maybe someone of you can join the discussion with the GTK developers in their bug tracker, because I am really not in the topic. :)
Comment 10 Martin Flöser 2015-08-11 08:39:42 UTC
> As far as I understand, the best solution would be if they give the possibility to disable the CSD right?

yes

> If this is the case, maybe someone of you can join the discussion with the GTK developers in their bug tracker, because I am really not in the topic. :)

GNOME/GTK developers are aware of the fact that we would like this to be changed. Unfortunately I don't think there is any point in me or Thomas commenting further on their bug tracker about it. I have a feeling that our points are not considered as we are seen as people who just oppose the idea of CSD and are not forward oriented. I rather think that only users can at this point show that this needs changing. In the worst case by using the feet and switching to non-GTK applications.
Comment 11 Thomas Lübking 2015-09-21 06:07:26 UTC
*** Bug 352960 has been marked as a duplicate of this bug. ***
Comment 12 Justin Zobel 2021-03-10 00:32:33 UTC
Thank you for the bug report.

As this report hasn't seen any changes in 5 years or more, we ask if you can please confirm that the issue still persists.

If this bug is no longer persisting or relevant please change the status to resolved.
Comment 13 Vlad Zahorodnii 2023-01-18 13:15:55 UTC
We added support for client-side decorations in kwin.