Bug 351026 - okular compilation requires qjson, but does not check for it
Summary: okular compilation requires qjson, but does not check for it
Status: RESOLVED UPSTREAM
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-06 09:48 UTC by Carl-Daniel Hailfinger
Modified: 2015-08-09 16:20 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
build/CMakeFiles/okularcore.dir/link.txt (3.07 KB, text/plain)
2015-08-06 22:29 UTC, Carl-Daniel Hailfinger 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Carl-Daniel Hailfinger 2015-08-06 09:48:06 UTC 
The cmake configuration step does not check if libqjson headers are installed, but compilation of okular fails if they are unavailable.

Reproducible: Always

Steps to Reproduce:
1. Run cmake without libqjson-dev installed
2. No error from the configure step
3. make

Actual Results:  
Error from ld: -lqjson can't be found

Expected Results:  
Compilation works

After installing libqjson-dev, compilation worked as expected. I would have expected cmake to check for libqjson header availability and error out.

Thank you for developing okular, it is very much appreciated!
Comment 1 Carl-Daniel Hailfinger 2015-08-06 09:49:03 UTC 
This is latest okular from git as of 2015-08-06.
Comment 2 Albert Astals Cid 2015-08-06 20:43:07 UTC 
kdeunstable@xps:~/okular:master$ wcgrep qjson
kdeunstable@xps:~/okular:master$

?
Comment 3 Carl-Daniel Hailfinger 2015-08-06 22:29:20 UTC 
Created attachment 93922 [details]
build/CMakeFiles/okularcore.dir/link.txt
Comment 4 Carl-Daniel Hailfinger 2015-08-06 22:30:41 UTC 
build/CMakeFiles/okularcore.dir/link.txt is where qjson gets mentioned. It is attached.
Comment 5 Luigi Toscano 2015-08-06 22:37:17 UTC 
(In reply to Carl-Daniel Hailfinger from comment #4)
> build/CMakeFiles/okularcore.dir/link.txt is where qjson gets mentioned. It
> is attached.

Could you please also paste the output of
git show --summary
?
Comment 6 Carl-Daniel Hailfinger 2015-08-06 23:10:00 UTC 
$ git show --summary
commit 346e7a32eab9c00333794aca590a4a5bb8954bfd
Merge: ba28b64 e2b5bc5
Author: Albert Astals Cid <aacid@kde.org>
Date:   Thu Aug 6 00:31:59 2015 +0200

    Merge remote-tracking branch 'origin/Applications/15.08'
    
    Conflicts:
        VERSION
        core/document.cpp
        core/version.h
Comment 7 Rex Dieter 2015-08-08 21:54:51 UTC 
The qjson dep (most likely) comes from elsewhere, libkscreen :
# LibKScreenTargetsWithPrefix-release.cmake:
IMPORTED_LINK_INTERFACE_LIBRARIES_RELEASE "Qt4::QtCore;-lpthread;KDE4__kdecore;qjson"

(at least on my fedora systems it does)
Comment 8 Albert Astals Cid 2015-08-09 16:20:31 UTC 
As Rex says, not an Okular bug.