Bug 350286 - Add a Photo Filter/Look filter for filter layers.
Summary: Add a Photo Filter/Look filter for filter layers.
Status: CONFIRMED
Alias: None
Product: krita
Classification: Applications
Component: layer styles (show other bugs)
Version: 2.9.4
Platform: Arch Linux Linux
: NOR wishlist
Target Milestone: ---
Assignee: Krita Bugs
URL: http://i.imgur.com/E2ko2Yl.jpg
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-16 09:57 UTC by Maugre
Modified: 2018-01-03 12:02 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Demo .PSD file (2.87 MB, image/vnd.adobe.photoshop)
2015-07-16 09:59 UTC, Maugre
Details
psd with color overlay rendered in Krita (1.15 MB, image/vnd.adobe.photoshop)
2015-08-18 08:55 UTC, Halla Rempt
Details
krita next to photoshop (282.08 KB, image/png)
2015-08-22 07:27 UTC, Halla Rempt
Details
Testcases for PS fill and adjustment layers, with descriptions (3.05 MB, application/octet-stream)
2016-01-01 18:16 UTC, Sven Claussner
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Maugre 2015-07-16 09:57:26 UTC
A client sent us a .PSD file to extract images for their product menu. The .PSD uses several versions of an image with color overlays to highlight the differences.

Okular handles these fine but Krita doesn't load the styles from the PSD. I can manually set the styles in Krita's layer settings.

The linked image shows Okular on the left (correct) with Krita on the right (some colours missing).

I wasn't sure if this is related to bug #350114. That was the closest open bug to the problem I am seeing.

Reproducible: Always

Steps to Reproduce:
1. Open PSD file

Actual Results:  
Some layers are missing the expected colour overlays


Pacman reports Krita version 2.9.6-1 is installed. The -1 is presumably a patch addition by Arch linux or Manjaro (I use Manjaro).
Comment 1 Maugre 2015-07-16 09:59:10 UTC
Created attachment 93613 [details]
Demo .PSD file
Comment 2 Halla Rempt 2015-08-11 14:09:58 UTC
Hi!

What Okular does is load the merged image part of the psd file. Krita tries to load the entire image and skips the parts that it doesn't know about, such as clipping paths, vector objects, text objects and color overlays. I'm not even sure that Krita already has a comparable feature :-)
Comment 3 Maugre 2015-08-13 16:34:28 UTC
Hi, Boudewijn!

Thank you for the response. I hadn't realised that it's a new feature (which I am pleased to see) in 2.9.4 called 'layer styles' as mentioned on this blog post: https://krita.org/item/krita-2-9-4-released/

I can set a colour overlay from the layer styles window (right-click the layer) so I have no doubt that loading from .PSD will be in a future release.
Comment 4 Halla Rempt 2015-08-18 08:55:33 UTC
Created attachment 94092 [details]
psd with color overlay rendered in Krita

Ah, I'm behind the times then. If it's part of layerstyles, then we should save and load it. I've also attached a PSD file, created in Krita with a color overload. Krita loads and saves it fine, but Photoshop messes it up. (Well, Krita also makes a mess of one thing: the bottom layer isn't rendered correctly anymore...)
Comment 5 Dmitry Kazakov 2015-08-19 13:18:47 UTC
In the demo file, it is *not* layers style "Color Overlay". Instead there is a special "Adjustment layer" with "Photo Filter". The latter is not supported in Krita. At least "yet".

The the file with a real "Color Overlay" layer style is opened by Photoshop fine.
Comment 6 Halla Rempt 2015-08-19 13:22:00 UTC
Hm... The file I attached was totally broken in CS2 on Linux, the layer 2 squiggle was partly outside the image. That looked okay in CS2 on Windows, but there the squiggle in the first  layer was transparent, while it should have been black...
Comment 7 Dmitry Kazakov 2015-08-19 16:29:34 UTC
First layer is also transparent when loading in Krita
Comment 8 Halla Rempt 2015-08-19 16:41:58 UTC
Which is both inconsistent and incorrect: it was white, the line was black when I created the image. Photoshop CS2 on Windows loads the layer as white and the line as transparent...
Comment 9 Dmitry Kazakov 2015-08-20 07:31:30 UTC
Boud, could you actually explain is steps, probably with screenshots, what the image was and what it is expected to be. I actually don't understand what is wrong with it, because the file you provided opens fine and consistently in Krita and Photoshop CS4.

The difference in the background may be related to the fact that Photoshop doesn't have an option to save a background color and you chose black as your projection color. In this case we should just create an additional layer in a PSD file to handle it. But this is not a bug, but more a wishlist. If so, please formulate the tasks which should be fixed, with screenshots and steps to reproduce.
Comment 10 Maugre 2015-08-21 14:50:20 UTC
(In reply to Dmitry Kazakov from comment #5)
> In the demo file, it is *not* layers style "Color Overlay". Instead there is
> a special "Adjustment layer" with "Photo Filter". The latter is not
> supported in Krita. At least "yet".

OK. Thanks for looking at this. I wasn't aware of the difference (my employer hasn't provided a PS license - I have no use for it privately so donated to Krita instead - so I haven't been able to check the original) and assumed it is a color overlay. My apologies.

I look forward to support for any additional features in future Krita releases. :)
Comment 11 Halla Rempt 2015-08-21 15:07:29 UTC
Thanks for supporting Krita :-) I'll mark this with the right psd feature for now, and as a wish bug.
Comment 12 Halla Rempt 2015-08-22 07:27:10 UTC
Created attachment 94160 [details]
krita next to photoshop

For my psd file, here's photoshop and krita next to each other. Krita doesn't render the bottom layer at all, even though there's a squigle there. Photoshop does other weird stuff...
Comment 13 Sven Claussner 2016-01-01 18:16:57 UTC
Created attachment 96401 [details]
Testcases for PS fill and adjustment layers, with descriptions

Hi,

I created some test cases for PS fill and adjustment layers support in GIMP, but think that Krita would benefit from them, too. I post it in the hope that GIMP and Krita developers could support each other in questions to PS support.
In a quick test Krita 2.9.9 (git b4ac381) on OS X opened and showed the layers but without function. 
For more information see:
GIMP glossary: PSB and PSD  - http://wiki.gimp.org/wiki/Glossary#PSB
GIMP Feature request - https://bugzilla.gnome.org/show_bug.cgi?id=79025

Sven
Comment 14 Halla Rempt 2016-01-24 14:16:58 UTC
WISHGROUP: Stretchgoal