Bug 350183 - Support of $VARIABLE in environment settings
Summary: Support of $VARIABLE in environment settings
Status: RESOLVED FIXED
Alias: None
Product: kdevelop
Classification: Applications
Component: Build tools: Make (show other bugs)
Version: 4.7.1
Platform: openSUSE Linux
: NOR wishlist
Target Milestone: ---
Assignee: kdevelop-bugs-null
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2015-07-13 16:10 UTC by Denis Kuplyakov
Modified: 2016-01-10 23:47 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 5.0.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Denis Kuplyakov 2015-07-13 16:10:31 UTC
Can you please add a support of using $(SOME VARIABLE) in enviroment settings? It will make process of configuring environment much easier. Were configuring KDE5 enviroment some time ago and this functionality can make life a lot easier with commands like $A = $A:someting.

Reproducible: Couldn't Reproduce
Comment 1 Kevin Funk 2015-12-17 12:05:32 UTC
Definitely useful, I agree.

This should be relatively trivial to implement, wanna give it a try, Denis?
Comment 2 Denis Kuplyakov 2015-12-22 20:53:01 UTC
(In reply to Kevin Funk from comment #1)
> Definitely useful, I agree.
> 
> This should be relatively trivial to implement, wanna give it a try, Denis?

Sometimes it is hard to dive in the code you have never seen before. Maybe if I have enough time I will try it, but I think if it is trivial for somebody experienced with KDevelop, he should take this.
Comment 3 Kevin Funk 2016-01-10 23:47:55 UTC
Git commit 81aa2d3f4cc39a7d0cb5e5fbae02ecedafe2e22c by Kevin Funk.
Committed on 10/01/2016 at 23:46.
Pushed by kfunk into branch '5.0'.

Support of $VARIABLE in environment settings
FIXED-IN: 5.0.0

Summary:
Added the possibility to use $VARIABLE in environment settings.
After some discussion it was concluded, that we won't support defining a variable with other user defined variable. Only supported scenario is defining a variable with a system variable.

Test Plan: Tested with the added unit test and in practice.

Reviewers: kfunk

Subscribers: kdevelop-devel

Projects: #kdevelop

Differential Revision: https://phabricator.kde.org/D770

M  +5    -2    outputview/outputexecutejob.cpp
M  +20   -0    util/environmentgrouplist.cpp
M  +3    -0    util/environmentgrouplist.h
M  +3    -0    util/tests/CMakeLists.txt
A  +81   -0    util/tests/test_environment.cpp     [License: LGPL (v2+)]
A  +35   -0    util/tests/test_environment.h     [License: LGPL (v2+)]

http://commits.kde.org/kdevplatform/81aa2d3f4cc39a7d0cb5e5fbae02ecedafe2e22c