Bug 349821 - File layers do not support transformations or transform masks.
Summary: File layers do not support transformations or transform masks.
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Tools/Transform (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
: 351641 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-07-02 11:22 UTC by Raghavendra kamath
Modified: 2016-04-11 18:34 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Raghavendra kamath 2015-07-02 11:22:54 UTC
When applying transform mask and scalling down a file layer which is bigger than the layer boundary , the resulting layer gets cut or some of its part gets hidden.

Reproducible: Always

Steps to Reproduce:
1.open krita and Create an image of 5184 * 3456 pixels, draw something in it possibly covering edges and save it as a png

2. Create another image of 2048x2048 pixels

3.Add the first image as a file layer to the second image ( choose scale to image, although this doesn't do anything)

4. add transform mask to this file layer and add scale transformation such that the file layer is within the boundary of normal layer.


Actual Results:  
parts of file layer gets hidden, if you try to scale again the rest of the layer appears but as soon as you apply the transformation it gets cut or hidden.

Expected Results:  
tranform shouldn't hide part of file layer
Comment 1 Raghavendra kamath 2015-07-02 11:44:25 UTC
for more clarity you can check what's happening in the video linked below:
https://dl.dropboxusercontent.com/u/37777793/krita/filelayer.mp4
Comment 2 Stefano Bonicatti 2015-07-02 16:10:15 UTC
If i try to transform a file layer without the transform mask, i see in the application console output: WARNING: File Layer does not support transformations!

So i think it's not supposed to work with transform mask too.
Comment 3 Halla Rempt 2016-03-22 13:22:13 UTC
I tried:

* make the file layer return false when the user adds a transform mask: that doesn't work, it adds the transform mask to the layer underneath the file layer
* figure out how to disable the transform tool if a file layer is active. I'm not sure that's even possible anymore, even though we have something similar for vector tools.
Comment 4 Halla Rempt 2016-03-22 14:23:43 UTC
*** Bug 351641 has been marked as a duplicate of this bug. ***
Comment 5 Dmitry Kazakov 2016-04-11 18:34:34 UTC
Git commit caeff5a4dc1e16e2e5cb1c664372018ea3f7dd73 by Dmitry Kazakov.
Committed on 11/04/2016 at 18:34.
Pushed by dkazakov into branch 'master'.

Fix transforming layers bigger than the image in size
Related: bug 350510
Ref T2081

M  +38   -17   libs/image/kis_safe_transform.cpp
M  +0    -2    libs/ui/kis_file_layer.cpp

http://commits.kde.org/krita/caeff5a4dc1e16e2e5cb1c664372018ea3f7dd73