Bug 349756 - [patch] Run in terminal
Summary: [patch] Run in terminal
Status: RESOLVED FIXED
Alias: None
Product: kate
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-30 17:59 UTC by ederag
Modified: 2017-12-22 17:13 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
"run current file" in terminal (4.49 KB, patch)
2015-06-30 17:59 UTC, ederag
Details

Note You need to log in before you can comment on or make changes to this bug.
Description ederag 2015-06-30 17:59:34 UTC
Created attachment 93433 [details]
"run current file" in terminal

This patch was sent to kwrite-devel@kde.org,
on Fri Apr 11 23:24:38 2014, without any answer. 
Maybe the bug tracker is a better place to send patches ?

This patch allows to "run current file" in terminal.
This just outputs to the terminal plugin
either the full file name or its basename,
depending on settings.

This is very useful when the current file is a script, for instance. 
Especially combined with a keyboard shortcut.

For instance when octave is running in the terminal,
and "octave_script.m" is the current file,
a simple F4 issues "octave_script\n" in the octave console,
which accordingly makes octave run the script. Very handy.
Yes, I know that octave has an IDE now, but kate is nice,
and it could be useful for others too ?

The patch was against kate shipped with kde-4.12.

What do you think about it ?
Comment 1 Dominik Haumann 2015-08-21 15:03:07 UTC
Could you post the patch on https://git.reviewboard.kde.org/dashboard/ ? That would be great!
Comment 2 ederag 2015-09-03 10:18:30 UTC
(In reply to Dominik Haumann from comment #1)
> Could you post the patch on https://git.reviewboard.kde.org/dashboard/ ?
> That would be great!

Sorry, it says "The uploaded diff uses short revisions, but Review Board requires full revisions.
Please generate a new diff using the --full-index parameter."

Perhaps this is because I used mercurial to keep track of the changes, and generate the diff (git style, with the  "hg diff  -g" command). 
I could change the underlying diff command parameters, 
but anyway on openSUSE 13.2, diff does not accept the "--full-index" parameter.

I also looked at rbtools, to no avail, and documentation is scarce.

So I would need some guidance there...
Comment 3 Nate Graham 2017-12-06 20:57:23 UTC
Hello ederag,
I'm sorry for the very long response time! We are still interested in this patch; please use git to generate it, and submit it on http://phabricator.kde.org/. If you need any additional assistance, I'd be happy to provide it to the best of my ability.
Comment 4 ederag 2017-12-07 19:33:14 UTC
Don(In reply to Nate Graham from comment #3)
> Hello ederag,
> I'm sorry for the very long response time! We are still interested in this
> patch; please use git to generate it, and submit it on
> http://phabricator.kde.org/. If you need any additional assistance, I'd be
> happy to provide it to the best of my ability.

Done, phabricator accepted the patch easily.
https://phabricator.kde.org/D9244
Thanks for your interest.
Comment 5 Christoph Cullmann 2017-12-22 17:13:15 UTC
Git commit e0850455361cbe396c05647b9f4d9394fbd73a4f by Christoph Cullmann, on behalf of Ede Rag.
Committed on 22/12/2017 at 17:12.
Pushed by cullmann into branch 'master'.

allow to run current document in konsole

CHANGELOG: Allow to execute the current document in the terminal widget.

Differential Revision: https://phabricator.kde.org/D9244

M  +120  -6    addons/konsole/kateconsole.cpp
M  +20   -5    addons/konsole/kateconsole.h
M  +1    -0    addons/konsole/ui.rc

https://commits.kde.org/kate/e0850455361cbe396c05647b9f4d9394fbd73a4f