Hi, this is a wish to add diagonal stripes to the Mypaint-color-pop-up ( krita/src/calligra/krita/plugins/extensions/dockers/advancedcolorselector/kis_my_paint_shade_selector.cpp ) to update it. * How it look now on Krita without [shift+M shortcut] (... it was similar on Mypaint before 2010, this screenshot is from Mypaint at this time ) : https://durian.blender.org/wp-content/uploads/2009/11/mypaint-screenshot.jpeg * How it looks with diagonal stripes ( or since 2010 on Mypaint ) : http://www.davidrevoy.com/data/images/blog/2011/08/3_mypaint-9-1-homepage.jpg What it does ? It add sort of Saturation+Light stripes in fourth diagonal direction. So, the user can saturate and dark-shade ( for SSS on skin ) , or desaturate and enlight ( for Skin part in light ) with a single click instead of selecting saturation then light in two time. I guess it's a low hanging-fruit, because the diagonal stripe code equivalent exist on Mypaint already and was added with this commit https://github.com/mypaint/mypaint/commit/dd00c2694620d66289574b86b3f90afe0ff96f26 ( file in modern Mypaint : https://github.com/mypaint/mypaint/blob/b6d06a46f93065e31b9cc21143f05155bfec974f/lib/colorchanger_crossed_bowl.hpp#L125 ). The code is really similar from Mypaint to Krita, and I tried to mimic the pattern to make it work myself. I tried hard, but my low skill in converting 'if/elseif' from the python to C++ is bad and I can't build any of my attempts.
WISHGROUP: Larger Usability Fixes
Git commit cc82f9ea7c3d1a927ec1790099fca092678e37a3 by Dmitry Kazakov. Committed on 17/09/2020 at 20:24. Pushed by dkazakov into branch 'master'. Add diagonal lines to MyPaint Shade Selector M +7 -0 plugins/dockers/advancedcolorselector/kis_my_paint_shade_selector.cpp https://invent.kde.org/graphics/krita/commit/cc82f9ea7c3d1a927ec1790099fca092678e37a3
Git commit 1ee63d5dcaa73a5e4e6ebd7985cdf97d55a6aa31 by Dmitry Kazakov. Committed on 17/09/2020 at 22:17. Pushed by dkazakov into branch 'krita/4.3'. Add diagonal lines to MyPaint Shade Selector M +7 -0 plugins/dockers/advancedcolorselector/kis_my_paint_shade_selector.cpp https://invent.kde.org/graphics/krita/commit/1ee63d5dcaa73a5e4e6ebd7985cdf97d55a6aa31
I tested it and everything is working perfectly. Thank you very much Dmitry!