Bug 349523 - Name of selected contact is hardly visible when window is inactive
Summary: Name of selected contact is hardly visible when window is inactive
Status: RESOLVED FIXED
Alias: None
Product: telepathy
Classification: Unmaintained
Component: contactlist (show other bugs)
Version: unspecified
Platform: Fedora RPMs Linux
: NOR minor
Target Milestone: Future
Assignee: Telepathy Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-23 10:07 UTC by Alexander Potashev
Modified: 2015-06-23 15:36 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 15.04.3
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Potashev 2015-06-23 10:07:47 UTC
See "how to reproduce" below.

Reproducible: Always

Steps to Reproduce:
1. Open KTP contact list
2. Select a contact
3. Switch to another window

Actual Results:  
Because contact is selected, text color is white. Because the window is inactive, the selection background color is light blue with a very low intensity. It's hard to read white text on very light background.

Expected Results:  
Black text on light blue would look better.
Comment 1 Alexander Potashev 2015-06-23 10:08:19 UTC
Theme: Breeze with default color scheme.
Comment 2 Martin Klapetek 2015-06-23 10:15:05 UTC
Thanks for the report

That's a style problem really though, and I think there was already some report like that (different app).
Comment 3 Hugo Pereira Da Costa 2015-06-23 10:43:14 UTC
to Martin:
I do not think it is a style issue.
For inactive window and selected item, the foreground should switch back to black.
It is a case for instance in dolphin side panel (places). So there must be something specific to the contact list.
Comment 4 Martin Klapetek 2015-06-23 10:48:29 UTC
Aha, ok. I will check what we're doing with the list then.

Thanks
Comment 5 Martin Klapetek 2015-06-23 15:30:40 UTC
You are correct, Hugo, it's bug in our delegate.

Sorry for the noise :)
Comment 6 Martin Klapetek 2015-06-23 15:36:59 UTC
Git commit de4d38c734576cd6ea8e259bef60b29027ddd103 by Martin Klapetek.
Committed on 23/06/2015 at 15:36.
Pushed by mklapetek into branch 'Applications/15.04'.

Use QPalette::ColorGroup from the option rather than always QPalette::Active

When the window looses focus, the palette is no longer Active but
Inactive. The option.palette has the correct data, so this just reuses
it.
FIXED-IN: 15.04.3

M  +2    -2    contact-delegate-compact.cpp
M  +2    -2    contact-delegate.cpp

http://commits.kde.org/telepathy-contact-list/de4d38c734576cd6ea8e259bef60b29027ddd103