Unless I missed something, after the related .desktop file changes kcoreaddons_desktop_to_json() does not update the target. Instead, to force update (compiling-in a new json data) I need to: 1. re-run cmake in the builddie to update the json file 2. 'make clean' in the plugin's dir 3. make Reproducible: Always This is rather error-prone behaviour.
Created attachment 93255 [details] attachment-12666-0.html Confirmed also when doing the kreport port, was quite frustrating until I figured out why the changes werent being seen! :) On Fri, Jun 19, 2015 at 11:04 PM, Jarosław Staniek <staniek@kde.org> wrote: > https://bugs.kde.org/show_bug.cgi?id=349398 > > Bug ID: 349398 > Summary: kcoreaddons_desktop_to_json() does not update the > target > Product: frameworks-kcoreaddons > Version: 5.1.0 > Platform: Other > OS: Linux > Status: UNCONFIRMED > Severity: normal > Priority: NOR > Component: general > Assignee: mpyne@kde.org > Reporter: staniek@kde.org > CC: kdelibs-bugs@kde.org > > Unless I missed something, after the related .desktop file changes > kcoreaddons_desktop_to_json() does not update the target. > > Instead, to force update (compiling-in a new json data) I need to: > 1. re-run cmake in the builddie to update the json file > 2. 'make clean' in the plugin's dir > 3. make > > Reproducible: Always > > > > > This is rather error-prone behaviour. > > -- > You are receiving this mail because: > You are watching the reporter of the bug. >
Confirmed by Adam.
Going through old bugs, but I'm not able to reproduce this. The CMake code for this is in KF5CoreAddonsMacros.cmake, which seems to indicate that this might be a CMake bug fixed in CMake 3.0.0. If it's possible to reproduce with a more recent CMake please reopen, but the "touch desktop file; re-run make" trick worked fine for me.