Bug 349371 - startkde.cmake: Do not export QT_PLUGIN_PATH if $kdehome is not set
Summary: startkde.cmake: Do not export QT_PLUGIN_PATH if $kdehome is not set
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: general (show other bugs)
Version: 5.3.0
Platform: unspecified Linux
: VHI grave
Target Milestone: 1.0
Assignee: David Edmundson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-19 08:15 UTC by Kai Koehne
Modified: 2015-07-10 13:15 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.4.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kai Koehne 2015-06-19 08:15:44 UTC
The startkde.cmake script always exports QT_PLUGIN_PATH, which is not needed for distributions that install KDE plugins in the default plugin path. Anyhow, setting QT_PLUGIN_PATH nevertheless messes with 3rd party Qt installations.

OpenSUSE therefore patches startkde.cmake to remove the logic 

  https://build.opensuse.org/package/view_file/KDE:Frameworks5/plasma5-workspace/0003-Remove-export-of-QT_PLUGIN_PATH.patch?expand=1

and so does Fedora now. Anyhow, this wouldn't be necessary if the script would only export QT_PLUGIN_PATH if it's needed (that is, $kdehome is set).

Reproducible: Always
Comment 1 Lars Knoll 2015-06-25 08:46:18 UTC
Yes, can you please remove this? 

QT_PLUGIN_PATH is not something that should ever be set system wide. Currently this causes e.g. Qt Creator from installed with our installers to crash when running it on a KDE 5 desktop (e.g. in kubuntu 15.04).
Comment 2 David Edmundson 2015-07-03 09:41:46 UTC
Git commit be1c5fbfbcb436ef701799e6f1ebbabf8eca6f7c by David Edmundson.
Committed on 03/07/2015 at 09:40.
Pushed by davidedmundson into branch 'master'.

Don't export QT_PLUGIN_PATH

Currently we are modifying the plugin path to include
$kdehome/lib/kde5/plugins, the original change says this is to allow
users to load styles and such.

In Plasma 5 $kdehome is .config, which shouldn't contain any plugins, so
this line currently isn't achieving anything.

Apparently instead it was causing problems and various distros are
already patching it out without issue.
FIXED-IN: 5.4.0

M  +0    -6    startkde/startkde.cmake

http://commits.kde.org/plasma-workspace/be1c5fbfbcb436ef701799e6f1ebbabf8eca6f7c