Bug 349327 - Bad date format for sub-operation display in split tab
Summary: Bad date format for sub-operation display in split tab
Status: RESOLVED FIXED
Alias: None
Product: skrooge
Classification: Applications
Component: general (show other bugs)
Version: 1.12.5
Platform: Kubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Stephane MANKOWSKI
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-18 11:04 UTC by vicnet
Modified: 2015-06-25 18:32 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description vicnet 2015-06-18 11:04:18 UTC
If Skrooge is configured with fancy short date format as dd/mm/yyyy, operation list use this format, main part of edit panel seems to use it too, but split part panel always show date with its own format yyyy-mm-dd (ISO format ?)
More over, if configuration date format is changed to an exotic format (ISO ordinal for example :-)), list use this format but nor edit panel nor split panel use it.

Reproducible: Always

Steps to Reproduce:
1. Choose 'ISO ordinal' data format in configuration
2. Open operations, and select a split operation
3. Display the split panel

Actual Results:  
Date in main edit panel is dd/mm/yyyy
Date in split panel is yyyy-mm-dd

Expected Results:  
Date in main panel and split should be yyyy-ooo (iso ordinal).
Or if not doable, edit panel should have the same date format for main part and split part.
Comment 1 vicnet 2015-06-18 18:16:26 UTC
In fact, date should not be displayed nor editable in a split operation, only in a group operation.
Comment 2 Stephane MANKOWSKI 2015-06-25 12:52:16 UTC
(In reply to vicnet from comment #1)
> In fact, date should not be displayed nor editable in a split operation,
> only in a group operation.

Hi Vicnet,
The fact that dates are editable in split operation is not a bug, this is a feature.
I explain:
1-Imagine that you paid your insurance for the 01/01/2015, 100€ for 4 months (Jan. Feb. Mar. Apr.)
2-You would like to see this amount effected to the corresponding month in reports.
3-To do that, you just have to create a split like this:
01/01/2015 25€
01/02/2015 25€
01/03/2015 25€
01/04/2015 25€

In conclusion: 
The date of the operation is the date when your account has been affected.
The dates of sub operations is the date used for reports.

I will treat the display issue.
Comment 3 Stephane MANKOWSKI 2015-06-25 18:32:03 UTC
Git commit f9901743b8faa24bd536bb6caa50d676aae18c51 by Stephane Mankowski.
Committed on 25/06/2015 at 18:31.
Pushed by smankowski into branch 'master'.

Bad date format for sub-operation display in split tab

M  +1    -0    CHANGELOG
M  +2    -2    plugins/skrooge/skrooge_operation/skgoperationpluginwidget.cpp
M  +7    -3    plugins/skrooge/skrooge_operation/skgsplittabledelegate.cpp
M  +16   -0    skgbasegui/skgmainpanel.cpp
M  +7    -0    skgbasegui/skgmainpanel.h
M  +1    -14   skgbasegui/skgobjectmodelbase.cpp
M  +2    -2    skgbasemodeler/skgservices.cpp
M  +3    -3    skgbasemodeler/skgservices.h

http://commits.kde.org/skrooge/f9901743b8faa24bd536bb6caa50d676aae18c51