Bug 349142 - Notification popup is too small
Summary: Notification popup is too small
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Notifications (show other bugs)
Version: master
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Martin Klapetek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-14 11:26 UTC by Kai Uwe Broulik
Modified: 2015-06-22 16:53 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 5.3.2
Sentry Crash Report:


Attachments
Too small notification (18.87 KB, image/png)
2015-06-14 11:26 UTC, Kai Uwe Broulik
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kai Uwe Broulik 2015-06-14 11:26:11 UTC
Since recent changes to the NotificationPopup it usually is too small to fit any meaningful message in there. Sometimes I get two lines but most of the time I only get one line, if there are no action buttons.

Reproducible: Always

Steps to Reproduce:
1. Have KMail send you a notification
2.
3.

Actual Results:  
Usually you can just read the author

Expected Results:  
You can read the subject too
Comment 1 Kai Uwe Broulik 2015-06-14 11:26:39 UTC
Created attachment 93171 [details]
Too small notification
Comment 2 Martin Klapetek 2015-06-15 17:01:44 UTC
Yeah, the sizing is all sorts of weird now.

I need to make it more smarter.
Comment 3 Martin Klapetek 2015-06-22 16:53:23 UTC
Git commit 707a9b0bc74af62cdf1fe04cf11c6163a5006518 by Martin Klapetek.
Committed on 22/06/2015 at 16:53.
Pushed by mklapetek into branch 'Plasma/5.3'.

[notifications] Rework the notifications sizing code

This reworks the notification sizing computation to use Layouts. This
should fix all the popup sizing issues there are (including a binding
loop error).

Now it also properly elides after max 4 lines of text.

REVIEW: 124149
FIXED-IN: 5.3.2
Related: bug 339588

M  +75   -73   applets/notifications/package/contents/ui/NotificationItem.qml
M  +1    -0    applets/notifications/package/contents/ui/NotificationPopup.qml

http://commits.kde.org/plasma-workspace/707a9b0bc74af62cdf1fe04cf11c6163a5006518