Bug 349108 - Crash when redoing after updating to Krita: 2.9.5 (git c5aba5a)
Summary: Crash when redoing after updating to Krita: 2.9.5 (git c5aba5a)
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: General (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR crash
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-13 16:51 UTC by mvowada
Modified: 2015-06-14 15:35 UTC (History)
0 users

See Also:
Latest Commit: http://commits.kde.org/calligra/6c9bb986ab8fb7fbc2df36a4af65e7763aeb5f3c
Version Fixed In:

Attachments
GDB backtrace. (14.18 KB, text/plain)
2015-06-13 16:52 UTC, mvowada 		Details
Video. (156.86 KB, video/mp4)
2015-06-13 16:53 UTC, mvowada 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description mvowada 2015-06-13 16:51:30 UTC 
Whenever I redo a brush stroke I get a crash (see the backtrace below).
I've updated to Krita: 2.9.5 (git c5aba5a) today.

Reproducible: Always

Steps to Reproduce:
1. fresh configs
2. make a paint stroke
3. undo
4. redo

Actual Results:  
I get a crash.

Expected Results:  
Redo the paint stroke.
Comment 1 mvowada 2015-06-13 16:52:32 UTC 
Created attachment 93153 [details]
GDB backtrace.
Comment 2 mvowada 2015-06-13 16:53:40 UTC 
Created attachment 93154 [details]
Video.
Comment 3 Dmitry Kazakov 2015-06-14 15:35:38 UTC 
Git commit 6c9bb986ab8fb7fbc2df36a4af65e7763aeb5f3c by Dmitry Kazakov.
Committed on 14/06/2015 at 15:29.
Pushed by dkazakov into branch 'calligra/2.9'.

Fix a crash when redoing actions

We should clear redo stack tail only in case we are running non-undo/redo
stroke.
Related: bug 331708

M  +1    -0    krita/image/commands_new/kis_saved_commands.cpp
M  +4    -1    krita/image/kis_image.cc
M  +11   -0    krita/image/kis_stroke_strategy.cpp
M  +11   -0    krita/image/kis_stroke_strategy.h
M  +5    -0    krita/image/kis_stroke_strategy_undo_command_based.cpp
M  +2    -0    krita/image/kis_stroke_strategy_undo_command_based.h

http://commits.kde.org/calligra/6c9bb986ab8fb7fbc2df36a4af65e7763aeb5f3c