Bug 349014 - No ALERT Highlighting within comments for Fortran
Summary: No ALERT Highlighting within comments for Fortran
Status: RESOLVED FIXED
Alias: None
Product: kate
Classification: Applications
Component: syntax (other bugs)
Version First Reported In: Git
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2015-06-11 07:47 UTC by Christian Butcher
Modified: 2018-09-30 07:35 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 5.51
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Butcher 2015-06-11 07:47:35 UTC
Many of the other languages with syntax highlighting allow ALERT highlighting within comments

I tried to place an appropriate
    <IncludeRules context="##Alerts" /> 
line but couldn't get it anywhere correct - placing it within the 
<context .. name="find_comments">
  ...
</context>
section created highlighting for ALERTS, but not within comments.


Reproducible: Always

Steps to Reproduce:
1. Create a Source/Fortran highlighted file
2. Type a comment like ! TODO - fix this issue


Actual Results:  
Comment in standard grey

Expected Results:  
Comment in highlighted ALERT style

Similar 'bugs' have been reported for Python ('fixed'): https://bugs.kde.org/show_bug.cgi?id=194997 and R (patch submitted, but unsure if this has been 'fixed'): https://bugs.kde.org/show_bug.cgi?id=344442

I'm not sure how to go about changing this, or else I'd provide an equivalent patch
Comment 1 Buovjaga 2016-06-25 14:41:10 UTC
Please attach an example file as I am not sure, how to reproduce this.
Comment 2 Andrew Crouthamel 2018-09-26 22:20:41 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days, the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information.

For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please set the bug status as REPORTED so that the KDE team knows that the bug is ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 3 Dominik Haumann 2018-09-30 07:35:07 UTC
Git commit aedf21f9b42ebbcd268676903ab9a34110de7703 by Dominik Haumann.
Committed on 30/09/2018 at 07:34.
Pushed by dhaumann into branch 'master'.

Fortran: Highlight alerts in comments

FIXED-IN: 5.51

M  +7    -3    data/syntax/fortran.xml

https://commits.kde.org/syntax-highlighting/aedf21f9b42ebbcd268676903ab9a34110de7703