Bug 348904 - IMPP and CATEGORIES vcard properties are not synced when using CardDav resource.
Summary: IMPP and CATEGORIES vcard properties are not synced when using CardDav resource.
Status: RESOLVED FIXED
Alias: None
Product: kdepimlibs
Classification: Applications
Component: kabc (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR major
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-08 22:43 UTC by Magnus Westin
Modified: 2016-09-21 13:16 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
VCARD 3.0 file that contain an example of tags that isn't saved. (368 bytes, text/vcard)
2015-07-02 19:24 UTC, Magnus Westin
Details
VCARD file with all IMPP fields that owncloud can generate (808 bytes, text/vcard)
2015-07-05 07:43 UTC, Magnus Westin
Details
VCARD file with URL and TYPE information. (954 bytes, text/vcard)
2015-07-18 10:10 UTC, Magnus Westin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Magnus Westin 2015-06-08 22:43:00 UTC
When I sync from KContact to OwnCloud some data is lost. Mainly IMPP and CATEGORIES are missing. This is major. A minor issue is that the TYPE information for the URL property is also lost.

I'm not sure if I'm looking at the correct code, but I checked vcardtool.h and vcardtool.cpp in kcontacts repository and it seems like the code is missing for IMPP and URL issues. For the CATEGORIES issue there is a comment: 
//Laurent: 31 Jan 2015. Not necessary to export it. When Categories were changes as AkonadiTag nobody thought that it was break categorie support...
//=> not necessary to export just tag...

Not sure what that refers too, but the effect is that change removes CATEGORIES property on sync.

Reproducible: Always

Steps to Reproduce:
1. Setup sync to a CardDav server that uses IMPP and CATEGORIES properties (OwnCloud)
2. Setup sync in Akonadi as a "Dav Groupware Resource"
3. Sync from Akonadi to server.

Actual Results:  
IMPP and CATEGORIES properties are gone. And the TYPE filed for URL is also missing.

Expected Results:  
IMPP and CATEGORIES properties and TYPE field for URL are syncted correctly.
Comment 1 Grégory Oestreicher 2015-06-25 21:05:52 UTC
Hey,

Could you add a sample .ics that fails to sync? Also does this only happens with the dav resource and not with a simple one, like a file-based calendar?

Cheers,
Grégory
Comment 2 Laurent Montel 2015-06-28 08:30:42 UTC
//Laurent: 31 Jan 2015. Not necessary to export it. When Categories were changes as AkonadiTag nobody thought that it was break categorie support... //=> not necessary to export just tag... 
it's normal tag format was changes. It saves as a akonadi id not a real tag.
So we can export it but when we sync it will lose too.
Comment 3 Magnus Westin 2015-07-02 19:24:38 UTC
Created attachment 93462 [details]
VCARD 3.0 file that contain an example of tags that isn't saved.
Comment 4 Magnus Westin 2015-07-02 19:25:36 UTC
I attached a VCARD 3.0 file that have CATEGORIES and IMPP tags that isn't synced back to OwnCloud.
Comment 5 Allen Winter 2015-07-02 19:53:25 UTC
I don't think this has anything at all to do with CardDAV nor Akonadi.
This is about vCard extensions that we apparently are not supporting in our kabc library.

should be re-assigned accordingly
Comment 6 Laurent Montel 2015-07-02 21:09:21 UTC
I started to implement IMPP some months ago.
It's not finish yet but I will try to finish it for kf5 15.08

Regards
Comment 7 Laurent Montel 2015-07-02 21:11:32 UTC
I will improve it
Comment 8 Laurent Montel 2015-07-03 04:58:07 UTC
(In reply to Magnus Westin from comment #3)
> Created attachment 93462 [details]
> VCARD 3.0 file that contain an example of tags that isn't saved.

Thanks for it.
Is it possible to provide me another test with a lot of IMPP (for example google, irc etc.)
I need example for it to validate my code.
Thanks a lot.
Comment 9 Magnus Westin 2015-07-05 07:43:27 UTC
Created attachment 93479 [details]
VCARD file with all IMPP fields that owncloud can generate

Here is an attachment with all IMPP fields that owncloud can generate as of version 8.0.4. It also contains the CATEGORIES tag.
Comment 10 Laurent Montel 2015-07-05 08:09:21 UTC
Thanks a lot!
I continue to work on impp support so it will help me a lot.
Regards
Comment 11 Laurent Montel 2015-07-06 15:17:09 UTC
"And the TYPE filed for URL is also missing. " could explain more please ?
Comment 12 Laurent Montel 2015-07-06 19:02:40 UTC
Git commit 3950afeb271eca2a4b7a1a155f8b4a034c3f942a by Montel Laurent.
Committed on 06/07/2015 at 18:45.
Pushed by mlaurent into branch 'master'.

Add support for IMPP

M  +110  -0    autotests/impptest.cpp
M  +7    -0    autotests/impptest.h
M  +3    -3    src/impp.cpp
M  +3    -2    src/impp.h
M  +6    -0    src/vcardtool.cpp

http://commits.kde.org/kcontacts/3950afeb271eca2a4b7a1a155f8b4a034c3f942a
Comment 13 Laurent Montel 2015-07-06 19:04:37 UTC
Now impp is save/load. But we can't still use in kaddressbook. It needs more work.
I will continue it.
Comment 14 Magnus Westin 2015-07-18 10:10:19 UTC
(In reply to Laurent Montel from comment #11)
> "And the TYPE filed for URL is also missing. " could explain more please ?

Sorry, I missed that question. A lot of the data in Dav can have a type field. For example the "Address" field has a type, where you can specify "Home", "Work", etc. This doesn't save for the URL field. Owncloud supports: WORK, HOME, INTERNET and OTHER. But I think the standard says you can put any type of text there. I will attach a new VCARD with the URL property that has the TYPE field.
Comment 15 Magnus Westin 2015-07-18 10:10:50 UTC
Created attachment 93638 [details]
VCARD file with URL and TYPE information.
Comment 16 Laurent Montel 2015-07-18 14:05:32 UTC
Ah yep indeed I stored just url.
Ok thanks for info I will fix it soon.
Comment 17 Laurent Montel 2015-07-19 13:03:42 UTC
I fixed it in kf5 (kcontact-4.90)
Comment 18 Denis Kurz 2016-09-21 13:16:38 UTC
Noone seems to disagree with comment 17, closing.