After editing, saving and finally closing a translation file, the file selector in the project view jumps to a new, seemingly random, file. It should instead stay at just edited file. Reproducible: Always Steps to Reproduce: 1. Checkout a KDE translation messages folder for a language (including the subfolders). 2. Create/open a project for this folder. 3. Open a subfolder in the project view. 4. Open a file from the subfolder in step 3, either using the mouse or the keyboard. 5. Edit the file (make at least one change). 6. Save the file (Ctrl + S). 7. Close the file (Ctrl + W). Actual Results: The file selector has moved to (i.e. selected) a completely different file. Expected Results: The file just edited should stay selected.
15.12 is going to improve in this regard (actually already in the master branch)
I still have this problem in 15.12 and ‘master’.
I can confirm that. It happens only if I translated a template pot file (there is no po file). The problem looks like that Lokalize detects the new po file and refresh the whole list! There should be a way to workaround this.. I'm using: KDE Frameworks 5.18.0 Qt 5.5.1 (built against 5.5.1) The xcb windowing system
It does indeed seem to happen due to #343371. Hopefuly, fixing #343371 will fix this issue as well.
Git commit b6f3151185b746092ad1b2e2ede5130e02c9dc02 by Simon Depiets. Committed on 29/08/2018 at 02:10. Pushed by sdepiets into branch 'master'. Fix project model issues on file changes Summary: This revision fixes some issues with the Project Model refreshes - Project view jumps to new (random?) file after closing translation file https://bugs.kde.org/show_bug.cgi?id=348757 - Whole project is refreshed when a file is changed https://bugs.kde.org/show_bug.cgi?id=343371 - Moving or adding a file/folder into the project root will trigger a bug where only that file/folder is displayed It mostly fixes behaviors which are applied to directories while they shouldn't (like cache requests for directories that return empty values, or unnecessary full regeneration). Related: bug 343371 Test Plan: I've tested the following test matrix : * Move/Add/Remove/Save x File or Folder * Within the root folder, within subfolders (same or different), between the root and a subfolder This is for a .po project architecture, I would be interested to know if the behavior doesn't create regressions with a .po/.pot or other architecture (which might be more buggy to begin with). Reviewers: ltoscano, #localization, aacid, mlaurent Tags: #localization Differential Revision: https://phabricator.kde.org/D15049 M +29 -13 src/project/projectmodel.cpp https://commits.kde.org/lokalize/b6f3151185b746092ad1b2e2ede5130e02c9dc02