Bug 348742 - Fill with foreground / background shortcut diregards opacity setting
Summary: Fill with foreground / background shortcut diregards opacity setting
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: General (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-05 12:13 UTC by truekikim
Modified: 2015-08-12 13:20 UTC (History)
1 user (show)

See Also:
Latest Commit: http://commits.kde.org/calligra/a0d213b2016d9e89d1504b708c28526a4f151019
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description truekikim 2015-06-05 12:13:57 UTC 
Previously when I used the shortcut for fill with foreground or fill with background it used my current bush opacity settings from the top panel. Now it always fills with 100% opacity.

Reproducible: Always
Comment 1 Halla Rempt 2015-06-20 19:06:25 UTC 
Erm, yes... That was done to fix this bug: https://bugs.kde.org/show_bug.cgi?id=329691 ( "Edit > Fill With Foreground/Background colors" should not be influenced by user opacity (Slider)), so it was kind of intentional...
Comment 2 Halla Rempt 2015-06-20 19:15:20 UTC 
So, this is getting interesting. We could make it a setting, old behaviour or new behaviour. We could add two more shortcuts for fill fg/fill bg with opacity or we could (but won't) interrupt the user's flow with a dialog, like photoshop does :-)
Comment 3 Halla Rempt 2015-06-20 19:23:30 UTC 
gimp: has ctrl + , and ctrl + . for opaque fill fg/bg
krita: backspace and shift-backspace for opaque fill fg/bg
so, maybe ctrl-backpace and ctrl-shift-backspace for global opacity fill fg/bg?
Comment 4 truekikim 2015-06-20 23:37:53 UTC 
As I see it, filling with the same thing that I am using to paint at the moment feels much more intuitive and useful than always with opaque. It gives way more possibilities and seems like more obvious and expected result. So I'd say that keeping the transparency settings could be a better suited choice for the default fill behaviour. But I guess people who migrate from other software where fully opaque fill short cut was a standard tool might have developed some strong habits :)
Maybe even an option to fill with all the settings of current brush (so also texture etc) could be a nice and intuitive option?
Comment 5 Halla Rempt 2015-08-12 13:06:35 UTC 
Hm, and phtooshop has alt backspace/ctrl backspace, but also does an opaque fill of the layer.
Comment 6 Halla Rempt 2015-08-12 13:20:48 UTC 
Git commit a0d213b2016d9e89d1504b708c28526a4f151019 by Boudewijn Rempt.
Committed on 12/08/2015 at 13:19.
Pushed by rempt into branch 'calligra/2.9'.
Related: bug 329691

Now we have both options: fill opaque, as in gimp and photoshop,
and fill with the current opacity, which we used to have. The
default shortcuts have Shift added to respect the current opacity.

M  +3    -1    krita/ui/actions/kis_selection_action_factories.cpp
M  +39   -1    krita/ui/kis_selection_manager.cc
M  +6    -0    krita/ui/kis_selection_manager.h

http://commits.kde.org/calligra/a0d213b2016d9e89d1504b708c28526a4f151019