Bug 348686 - knetwalk 3.3.0 does not update network node icons
Summary: knetwalk 3.3.0 does not update network node icons
Status: RESOLVED FIXED
Alias: None
Product: knetwalk
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: Ashwin Rajeev
URL:
Keywords:
: 389399 399877 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-06-04 07:35 UTC by Max
Modified: 2020-05-12 17:45 UTC (History)
9 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Screenshot showing the bug (95.33 KB, image/png)
2016-12-11 15:31 UTC, Hatto Von Hatzfeld
Details
new version file qml/logic.js (2.81 KB, text/plain)
2017-01-02 17:06 UTC, Hatto Von Hatzfeld
Details
improved version file qml/logic.js (2.86 KB, text/plain)
2017-01-02 19:54 UTC, Hatto Von Hatzfeld
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Max 2015-06-04 07:35:05 UTC
When network node gets connected/disconnected the icon should change accordingly, however it remains the same it was when game was started.

Reproducible: Always

Steps to Reproduce:
1.Start new game
2.Connect any disconnected node to the source
3.
Comment 1 Stefan Hinz 2016-04-04 16:12:34 UTC
Note that this is new as of KDE 5 (at least for me it is). In KDE 4, those KNetWalk monitors would turn on properly when connected to the server.
Comment 2 dmatt 2016-05-09 13:10:32 UTC
I confirm this bug is also present in knetwalk on Kubuntu 16.04. Sound of turning on/off is present, icon does not update.

Version 3.3.0
Using:
KDE Frameworks 5.18.0
Qt 5.5.1 (built against 5.5.1)
The xcb windowing system
Comment 3 Hatto Von Hatzfeld 2016-12-11 15:31:12 UTC
Created attachment 102728 [details]
Screenshot showing the bug

I can confirm this bug. Neither connecting nor disconnecting a node causes the node icon to change. In former versions (KDE 4) this used to work.

KDE Frameworks 5.21.0
Qt 5.5.1 (kompiliert gegen 5.5.1)
Das xcb Fenstersystem

Repository: KDE 5 Applications
Name: knetwalk
Version: 16.11.90-2.6
Arch: x86_64
Vendor: obs://build.opensuse.org/KDE
Comment 4 Hatto Von Hatzfeld 2017-01-02 17:06:23 UTC
Created attachment 103145 [details]
new version file qml/logic.js

Substituting the file logic.js (in my case located in /usr/share/knetwalk/qml/) solves this bug. There's just one line which has been added.

No new compiling needed, so this can be done even by beginners.

Should work in versions at least from 15.04 to 16.12, probably more.
Comment 5 Max 2017-01-02 17:12:38 UTC
This fix works, thank you. Not sure however, it may create a memory leak. May be destroy previous object too? It requires to store object links somewhere.
Comment 6 Hatto Von Hatzfeld 2017-01-02 19:54:26 UTC
Created attachment 103149 [details]
improved version file qml/logic.js

Substituting the file logic.js (in my case located in /usr/share/knetwalk/qml/) solves this bug. This is an improved version which avoids to create unnecessary new nodes (and memory leaks).

No new compiling needed, so this can be done even by beginners.

Should work in versions at least from 15.04 to 16.12, probably more.
Comment 7 Max 2017-01-02 20:34:21 UTC
It works great! Thank you
Comment 8 Albert Astals Cid 2017-01-03 22:54:02 UTC
Git commit 6c6d71ad0822bf6b48e1c84a790ac1106e0af88b by Albert Astals Cid, on behalf of Hatto von Hatzfeld.
Committed on 03/01/2017 at 22:52.
Pushed by aacid into branch 'Applications/16.12'.

Fix network nodes not getting updated

M  +3    -0    src/qml/logic.js

https://commits.kde.org/knetwalk/6c6d71ad0822bf6b48e1c84a790ac1106e0af88b
Comment 9 Albert Astals Cid 2018-01-25 21:15:55 UTC
*** Bug 389399 has been marked as a duplicate of this bug. ***
Comment 10 Albert Astals Cid 2018-10-16 20:44:13 UTC
*** Bug 399877 has been marked as a duplicate of this bug. ***
Comment 11 Richard Hebert 2020-05-12 17:42:45 UTC
bug reappeared in 3.3.0 Using:
KDE Frameworks 5.18.0
Qt 5.5.1 (built against 5.5.1)
The xcb windowing system

exactly the same issue. used to work fine .. now when you connect or disconnect a terminal it dont show the color change in the terminal. reinstalled .. same issue. 

steps to reproduce : 1) start game 
                     2) flip in out , color stays black
Comment 12 Max 2020-05-12 17:45:52 UTC
(In reply to Richard Hebert from comment #11)
> bug reappeared in 3.3.0 Using:
> KDE Frameworks 5.18.0
> Qt 5.5.1 (built against 5.5.1)
> The xcb windowing system
> 
> exactly the same issue. used to work fine .. now when you connect or
> disconnect a terminal it dont show the color change in the terminal.
> reinstalled .. same issue. 
> 
> steps to reproduce : 1) start game 
>                      2) flip in out , color stays black

Works fine here

KDE Plasma Version: 5.18.5
KDE Frameworks Version: 5.68.0
Qt Version: 5.13.2