Bug 348582 - Generate ServiceMenu entries for each preset
Summary: Generate ServiceMenu entries for each preset
Status: CONFIRMED
Alias: None
Product: ark
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Arch Linux Linux
: NOR wishlist
Target Milestone: ---
Assignee: Elvis Angelaccio
URL:
Keywords:
Depends on: 348581
Blocks:
  Show dependency treegraph
 
Reported: 2015-06-02 11:38 UTC by Soukyuu
Modified: 2016-06-05 17:53 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Soukyuu 2015-06-02 11:38:21 UTC
Implementing configuration options (#348579) and presets (#348581) calls for an improvement to service menus as well. It would be nice to have new service menu entries auto-generated for each user preset. That would involve both generating the entry on user saving the preset and removing it on user deleting it.

Reproducible: Always

Steps to Reproduce:
1. create a preset with custom configuration
2. name it e.g. "RAR5 rr5"
3. open dolphin
4. select files -> rightclick -> compress...

Actual Results:  
"Compress..." service menu only lists the default entries

Expected Results:  
"Compress.." service menu now also lists the custom "as RAR rr5" entry.

This is part of https://forum.kde.org/viewtopic.php?f=83&t=126466
Comment 1 Elvis Angelaccio 2016-06-03 14:55:09 UTC
New dependency: https://phabricator.kde.org/D1761

Once this lands in master, it will be possible to dynamically create the Compress service menu for Dolphin.
Comment 2 Elvis Angelaccio 2016-06-05 17:53:35 UTC
Git commit c369264d6c9ba2763b338f025c359c1b4c86f66e by Elvis Angelaccio.
Committed on 05/06/2016 at 17:50.
Pushed by elvisangelaccio into branch 'master'.

Port service menus to KFileItemAction

The Compress and Extract service menus shown in Dolphin's context menu are now
provided by two new KFileItemAction plugins. This allows us to do a lot of
useful checks before actually showing the actions in the context menu.

We can also stop hardcoding the supported mimetypes for the Extract
menu. This is actually required in order to support the Extract menu when more
than one archive is selected. In this case Dolphin sends to the kfileitemaction
plugins the
generic 'application/octet-stream' mimetype, so we have to manually check
anyway the mimetype of any given URL (to be sure that Ark supports it).

This also paves the way to dynamically generate the service menus (e.g. based
on some kind of user preset).
Related: bug 189177, bug 268163
FIXED-IN: 16.08.0

Differential Revision: D1761

M  +22   -6    app/CMakeLists.txt
D  +0    -179  app/ark_addtoservicemenu.desktop
D  +0    -167  app/ark_servicemenu.desktop.cmake
A  +99   -0    app/compressfileitemaction.cpp     [License: GPL (v2+)]
A  +54   -0    app/compressfileitemaction.h     [License: GPL (v2+)]
A  +15   -0    app/compressfileitemaction.json
A  +103  -0    app/extractfileitemaction.cpp     [License: GPL (v2+)]
A  +54   -0    app/extractfileitemaction.h     [License: GPL (v2+)]
A  +13   -0    app/extractfileitemaction.json

http://commits.kde.org/ark/c369264d6c9ba2763b338f025c359c1b4c86f66e