Bug 348399 - Huge title bar
Summary: Huge title bar
Status: REPORTED
Alias: None
Product: Breeze
Classification: Plasma
Component: window decoration (show other bugs)
Version: unspecified
Platform: Fedora RPMs Linux
: NOR wishlist
Target Milestone: ---
Assignee: Hugo Pereira Da Costa
URL:
Keywords:
: 346594 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-05-29 14:11 UTC by André Martins
Modified: 2021-03-09 05:49 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
screenshot (163.99 KB, image/png)
2015-06-01 18:11 UTC, André Martins
Details
non-forcing-dpi with 2880-1800 resolution (472.23 KB, image/png)
2015-06-01 19:12 UTC, André Martins
Details
non-forcing-dpi with 1440-900 resolution (94.69 KB, image/png)
2015-06-01 19:13 UTC, André Martins
Details

Note You need to log in before you can comment on or make changes to this bug.
Description André Martins 2015-05-29 14:11:10 UTC
The new version of kde has a huge title bar.
I was able to resize it by going to Windows Manager > Windows Decorations > selecting breeze > option square (on the right of breeze) > Button size = Small
It should be a "Tiny" option or at least a stepper for pixel height.

Reproducible: Always
Comment 1 Hugo Pereira Da Costa 2015-05-29 14:30:47 UTC
Can you post screenshots of the said huge titlebars ? also of the one you are currently using ? 
For me to know if this is a bug or a 'feature'.

On this computer, titlebar looks like: 

http://wstaw.org/m/2015/05/29/plasma-desktopMo6934.png

With settings being: 
Button size = normal
Window title (font) size = 10
Other font sizes = 8

(note that with the new decoration API, button sizes scale with fonts)

Thanks in advance, 

Hugo
Comment 2 André Martins 2015-05-29 14:37:50 UTC
(In reply to Hugo Pereira Da Costa from comment #1)
> Can you post screenshots of the said huge titlebars ? also of the one you
> are currently using ? 
> For me to know if this is a bug or a 'feature'.
> 
> On this computer, titlebar looks like: 
> 
> http://wstaw.org/m/2015/05/29/plasma-desktopMo6934.png
> 
> With settings being: 
> Button size = normal
> Window title (font) size = 10
> Other font sizes = 8
> 
> (note that with the new decoration API, button sizes scale with fonts)
> 
> Thanks in advance, 
> 
> Hugo

Hi Hugo, thanks for the response.
Yep, for me that is huge. I usually like to have title bars half of that. I was used to that on the old kde.
Comment 3 Hugo Pereira Da Costa 2015-05-29 14:46:51 UTC
Double checking my own code (hehe), it seems the smalles button size right now corresponds to 1.5 the font size.
I guess indeed I can make a smaller one, equal to 1 time the font size, which is pretty much the minimum you can get. 
Will keep you posted.

Hugo
Comment 4 André Martins 2015-05-29 14:53:50 UTC
Yep I think equal to 1 will be perfect! Thanks!
Comment 5 Hugo Pereira Da Costa 2015-06-01 17:46:03 UTC
Hi again.
I have tried added a smaller size and it looks ugly. 
So I went back comparing with the smallest titlebar size we had with oxygen in kde4.
Well: if you use the small button size, and a font size that is the same in the window title as for the other widgets, the breeze titlebar is actually smaller (<20pix) as what you had with similar settings with oxygen, at least here. 
Can you try on your side ? 
note that you need to reduce *both* the button size and the font size. 
Also: please post screenshots of your decoration, with the exact values of the settings (buttons + font) that you use, as well as a screenshot of the corresponding "small" titlebar you had with oxygen.

Thanks, 

Hugo
Comment 6 André Martins 2015-06-01 18:11:49 UTC
Created attachment 92949 [details]
screenshot

Mine has 40 pixels with font at 8.
My ideal title bar would be 5 pixels in height :-)

Btw in a non related subject. I've noticed that the mouse doesn't have a 32 size, only 24 and 48. The Adwaita one has it, can you make it 32? Do you want me to fill a wish-list issue for this?
Thanks for looking into this
Comment 7 Hugo Pereira Da Costa 2015-06-01 18:16:23 UTC
Do you by any chance have a high-dpi screen ?
Comment 8 André Martins 2015-06-01 18:17:40 UTC
Oh I think it is worth to mention that I'm using a monitor with 2880x1800 pixels on a 15.6" screen (A "retina" MBP display)
Comment 9 Hugo Pereira Da Costa 2015-06-01 18:19:46 UTC
there is something funny indeed in your screenshot, for instance the margins around the icons look larger than mine (hence the question). Maybe there is some issue with the "scaling" rules of the decoration API. (which is based on plasma scaling) ...
Comment 10 Hugo Pereira Da Costa 2015-06-01 18:20:23 UTC
(In reply to djx from comment #8)
> Oh I think it is worth to mention that I'm using a monitor with 2880x1800
> pixels on a 15.6" screen (A "retina" MBP display)

ok. Likely related, in fact. (see comments above)
Comment 11 Hugo Pereira Da Costa 2015-06-01 18:23:13 UTC
... any chance you could test on a non high-dpi screen, with the same settings and report ?
Comment 12 André Martins 2015-06-01 18:27:55 UTC
(In reply to Hugo Pereira Da Costa from comment #11)
> ... any chance you could test on a non high-dpi screen, with the same
> settings and report ?

How will that differ? I will have to change DPI from 144 to the "normal" but it won't solve on my main screen.
I thought plasma5 had better integration with hi-dpi screens... It is painful with some applications thankfully I've found hacks for almost every program that I use.
Comment 13 Hugo Pereira Da Costa 2015-06-01 18:45:01 UTC
Well it must have some dpi awareness: your screenshot is definitly different from mine.
even when I use the same settings as you. So only the hardware differs ... 
But I must admit I'm no expert.
Comment 14 Hugo Pereira Da Costa 2015-06-01 18:46:32 UTC
If you can try compile the code from source, I can post some patches here for you to compile so that we get more debug output and compare between your setup and mine ...
Comment 15 André Martins 2015-06-01 18:54:36 UTC
Don't you have access to a hi-dpi screen?
Comment 16 Hugo Pereira Da Costa 2015-06-01 19:04:44 UTC
nope :(
Comment 17 André Martins 2015-06-01 19:12:24 UTC
Created attachment 92951 [details]
non-forcing-dpi with 2880-1800 resolution
Comment 18 André Martins 2015-06-01 19:13:13 UTC
Created attachment 92952 [details]
non-forcing-dpi with 1440-900 resolution
Comment 19 Hugo Pereira Da Costa 2015-06-02 15:11:42 UTC
Git commit 56bc52fe3c190358176ed201f1ab1905a59a2e8e by Hugo Pereira Da Costa.
Committed on 02/06/2015 at 15:11.
Pushed by hpereiradacosta into branch 'master'.

added tiny (=minimal) button size, for high-dpi screens

M  +1    -0    kdecoration/breezedecoration.cpp
M  +1    -0    kdecoration/breezesettingsdata.kcfg
M  +5    -0    kdecoration/config/ui/breezeconfigurationui.ui

http://commits.kde.org/breeze/56bc52fe3c190358176ed201f1ab1905a59a2e8e
Comment 20 Hugo Pereira Da Costa 2015-06-02 15:12:12 UTC
*** Bug 346594 has been marked as a duplicate of this bug. ***
Comment 21 Hugo Pereira Da Costa 2015-06-02 15:15:18 UTC
ok. Thanks for the screenshots. So not forcing dpi, your screenshots look more like mine. Most likely what happens is that the button size is scaled to the font size, but disregarding dpi (though there is still the issue that your margins around buttons seems larger than mine).
In any case, this is due to the decoration api, and not to breeze in itself.

I have pushed a smaller "tiny" button size in the commit above, that should help. 
However, might not be enough, but that the best I can do on breeze side. The rest would be a plasma/kwin issue ... 

Please keep me posted if the above suits you and close the bug report if you're happy
Comment 22 André Martins 2015-06-02 15:51:58 UTC
Thanks, once I got this under my machine I'll get back at this issue.
What about the mouse issue that I've talk about?

"Btw in a non related subject. I've noticed that the mouse doesn't have a 32 size, only 24 and 48. The Adwaita one has it, can you make it 32? Do you want me to fill a wish-list issue for this?"
Comment 23 Hugo Pereira Da Costa 2015-06-02 19:25:16 UTC
(In reply to djx from comment #22)
> Thanks, once I got this under my machine I'll get back at this issue.
> What about the mouse issue that I've talk about?
> 
> "Btw in a non related subject. I've noticed that the mouse doesn't have a 32
> size, only 24 and 48. The Adwaita one has it, can you make it 32? Do you
> want me to fill a wish-list issue for this?"

Well, that's a different issue (and in fact I missed it). I have no expertise on mouse cursor theme, and it is unrelated to window decoration, so possible experts possibly won't know about it.

Please fill a different bug report (product breeze, component: either general or icons), or talk directly to the relevant people at the VDG forum (open a new thread): https://forum.kde.org/viewforum.php?f=285

In general it is a good idea not to merge different unrelated topics to the same bug report because it makes things hard to track.

Thanks in advance,

Hugo
Comment 24 André Martins 2015-12-15 18:14:10 UTC
(In reply to Hugo Pereira Da Costa from comment #23)
> (In reply to djx from comment #22)
> > Thanks, once I got this under my machine I'll get back at this issue.
> > What about the mouse issue that I've talk about?
> > 
> > "Btw in a non related subject. I've noticed that the mouse doesn't have a 32
> > size, only 24 and 48. The Adwaita one has it, can you make it 32? Do you
> > want me to fill a wish-list issue for this?"
> 
> Well, that's a different issue (and in fact I missed it). I have no
> expertise on mouse cursor theme, and it is unrelated to window decoration,
> so possible experts possibly won't know about it.
> 
> Please fill a different bug report (product breeze, component: either
> general or icons), or talk directly to the relevant people at the VDG forum
> (open a new thread): https://forum.kde.org/viewforum.php?f=285
> 
> In general it is a good idea not to merge different unrelated topics to the
> same bug report because it makes things hard to track.
> 
> Thanks in advance,
> 
> Hugo

Is this already upstream and packed? If yes since which version?
Comment 25 Justin Zobel 2021-03-09 05:49:55 UTC
Thank you for the bug report.

As this report hasn't seen any changes in 5 years or more, we ask if you can please confirm that the issue still persists.

If this bug is no longer persisting or relevant please change the status to resolved.