Bug 348221 - Gwenview File > Save As dialog is just titled "Gwenview"
Summary: Gwenview File > Save As dialog is just titled "Gwenview"
Status: RESOLVED FIXED
Alias: None
Product: gwenview
Classification: Applications
Component: general (show other bugs)
Version: 5.0.0
Platform: Kubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: Gwenview Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-25 21:56 UTC by skierpage
Modified: 2017-09-20 18:00 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description skierpage 2015-05-25 21:56:37 UTC
The text input field in Gwenview's File > Save As... dialog behaves badly.

Reproducible: Always

Steps to Reproduce:
1. Open an image named "something.jpg" in Gwenview.
2. Choose File > Save As...
3. Try to rename it "new.jpg" by typing in "new".

Actual Results:  
Gwenview dialog appears.
BUG 1: The dialog title bar is just named "Gwenview", I would expect it to be named "Save File — Gwenview" like Dolphin.

In the Name field, "something" is highlighted and the extension isn't (good).
The 'n' replaces the selection so the filename is now "n.jpg" (good).
But BUG 2: the ".jpg" becomes the selection. So the next letter you type overwrites it, and you lose the extension, the file name is now "ne".
BUG 3: Press Ctrl-Z and there's no Undo; right-click, and the context menu has "Undo" but it's grayed out.

It's even worse if you're trying to prepend something, e.g. to change "IMG201505.jpg" to "crop_IMG201505.jpg".  You press left arrow to move to the start of the Name field, press 'c', everything following is highligted, and then the filename is "cr" and you've lost the original name if you don't press Cancel.

You have to cancel and repeat to get back to the original name.

Expected Results:  
Don't select the extension after I start typing.
Do enable Undo/Redo.

I opened up Kate and saved a file in that, and it had the same behavior. So this seems a more general failing. (I don't know how to change this bug report to a more general component.)  Dolphin's inline file Rename works fine.

I'm marking this Major because anyone with years of experience using File Save As is going to lose file names or extensions.

This is a pretty stock Kubuntu 15.04 but I'm  using the PPA for more recent KDE software.
Comment 1 Nate Graham 2017-09-09 01:58:56 UTC
Bug #2 seems to have been solved as of Kubuntu 17.04/KF 5.31, so only bug #1 remains. That should be an easy fix. Let's see if I can whip up a patch.
Comment 2 Nate Graham 2017-09-09 02:16:12 UTC
Patch submitted: https://phabricator.kde.org/D7746
Comment 3 Albert Astals Cid 2017-09-20 18:00:12 UTC
Git commit 7bfd9a54abba5ce3198654aa272ed1d2544f787a by Albert Astals Cid, on behalf of Nathaniel Graham.
Committed on 20/09/2017 at 18:00.
Pushed by aacid into branch 'master'.

Give Gwenview's Save As dialog a proper title: "Save Image"

Summary:

Gives Gwenview's Save As dialog a proper title: "Save Image"

Test Plan:
Tested in KDE Neon (dev unstable). Works as expected:

{F3903826}

Reviewers: #kde_applications, aacid, cfeck, broulik

Reviewed By: aacid, cfeck

Differential Revision: https://phabricator.kde.org/D7746

M  +1    -0    app/gvcore.cpp

https://commits.kde.org/gwenview/7bfd9a54abba5ce3198654aa272ed1d2544f787a