Bug 348097 - Predefined brush tip changes after resizing, if you have a tag selected for brush tips in brush editor and use a brush with a brush tip which is not in the selected tag
Summary: Predefined brush tip changes after resizing, if you have a tag selected for b...
Status: RESOLVED INTENTIONAL
Alias: None
Product: krita
Classification: Applications
Component: Tagging (show other bugs)
Version: 2.9.4
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Halla Rempt
URL:
Keywords:
: 348734 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-05-22 10:19 UTC by truekikim
Modified: 2021-04-09 13:57 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description truekikim 2015-05-22 10:19:50 UTC
Brush tip automatically changes to a different one after I resize. I think it started after I used mange resources to add some photoshop brushes. 
For example I pick texture_fuzzy brush and when I resize it, the tip changes to the first brush from the photoshop pack. The settings are still from the texture_fuzzy brush, only the tip changes.

Reproducible: Always

Steps to Reproduce:
1. Manage resouces -> import an abr with some photoshop brushes
2. choose a krita brush with predefined tip (for example texture_fuzzy)
3. resize
4. the tip changes to a different one (first preset from the photoshop brush pack)
Comment 1 truekikim 2015-05-22 10:25:48 UTC
To prevent it from happening I must go to Edit brush settings choose the tab brush tip/predefined and from the dropdown list with names of brush packs select All (automatically it is set to the photoshop pack I added recently).
Comment 2 Halla Rempt 2015-05-29 09:24:30 UTC
Hi!

Which abr brush pack did you install exactly? Could you share it with us? I'm suspecting that there's overlap in the names of those brush tips and the ones we provide and that that's confusing the system that's loading the brush presets.
Comment 4 Halla Rempt 2015-05-29 10:09:34 UTC
Thanks!
Comment 5 Scott Petrovic 2015-06-20 13:16:10 UTC
I am having a difficult time understanding this issue in the most isolated form. Are you saying this problem only happens after importing ABR files?  I am having a difficult time reproducing this (2.9.5.1, Win 7 64-bit)

Test I performed::
1. Import the ABR pack
2. Go to the brush editor, predefined brush tip, and change my tag filter to the new tag that the ABR created
3.Select a tip
4. resize the brush diameter

Result: Tip stayed where it was


Reporter: Are you saying the brush tip changes every time you change the diameter of the brush?
Comment 6 truekikim 2015-06-20 16:55:12 UTC
I can't reproduce it any longer as now at the start of the program I can't resize predefined brushes at all as described in this bug:
https://bugs.kde.org/show_bug.cgi?id=348734
Comment 7 Raghavendra kamath 2015-07-05 12:47:11 UTC
I am confirming this.

This happens when you have tags in brush tip section. Importing a abr assigns its own tag to brush tip.

When you have one tag selected in the predefined brush tips section and use a brush with brush tip not in this tag, this issue happens. when you resize the brush tip is changes to the first tip of the tag.

This is not related to abr importing, this is related to tags in the brush tip.

To reproduce this bug do the following steps

1) Assign a tag to some brush tip. you can also import deevad's v6 bundle as that adds some tag to brush tip( the dragon head brush tip is tagged in deevad's bundle)

2) In the brush editor, under predefined brush tip select this newly created tag ( if you imported deevads bundle select '2015_04_17_deevadkrita_v6')

3) Now from the brush preset docker select a brush which uses a brush tip which is not tagged with the new tag you created.

4) Now Resize the brush, you'll notice that the brush tip is changed to the first listed brushtip in the new tag. Other properties of the brush remain same but the brush tip is changed to the first brush tip listed in the new tag.

5) Refreshing the brush preset is the only way to reset it. Also as a workaround keep 'all' tag in predefined brush tip selected then it behaves correctly.

I hope I have explained it correctly. 

Here's a video for more clarity. 
https://dl.dropboxusercontent.com/u/37777793/krita/brusheditor.mp4

please note that the abr tag in the video is created by me it is not related to Photoshop brush import. this bug is not because of photoshop brush import, this is because tags in predefined brush tips.Which co-incidentally creates a new tag when you import a photoshp abr.

Note: 
Stefano Bonicatti (Smjert) reported on IRC that he can reproduce it too.
I am changing the title of the bug too.
Comment 8 truekikim 2015-09-03 08:47:20 UTC
This is a part of the same bug as this one (which has been wrongly marked as fixed - it is still not fixed in 2.9.7): https://bugs.kde.org/show_bug.cgi?id=348734
Comment 9 wolthera 2015-11-22 14:58:22 UTC
*** Bug 348734 has been marked as a duplicate of this bug. ***
Comment 10 justinnicholillustration@gmail.com 2016-03-22 01:22:34 UTC
This bug is present for me also, using Ubuntu 15.10. The brush tip would change whenever I changed the size of the brush. This ceased when I removed a search term from the resource management bar in the brush dialog.
Comment 11 Storm Engineer 2016-03-26 01:47:38 UTC
Same issue. As Raghavendra kamath said it is about tags, not importing.

When in brush editor you have a tag selected that does NOT contain the brush tip you are using, the bug will trigger.


Suggestion: I already wanted to make a ticket for this, that would also work as a temp workaround for this bug: After Krita starts, anything that uses tags should default to "All" instead of having one - seemingly random - of the existing tags selected.
Comment 12 truekikim 2016-03-26 12:53:16 UTC
I agree that even this simple workaround partial solution would be a good idea.
Without selecting this "all" tag every time I start krita I can't even resize my brushes with predefined tips. Even though using tags will still be flawed (as it is now) but at least there won't be a problem right from the start of the program :)
Comment 13 Raghavendra kamath 2016-03-31 11:55:29 UTC
I deleted all the tags for predefined brush tips to avoid this. now in 3.0 this results in the tip getting locked and user cant resize the brush.
Comment 14 tomtomtomreportingin 2021-02-12 19:29:10 UTC
This bug still exists in stable as well as master, and it also happens with tagged patterns.
Steps to reproduce:
1. Select Dry Textured Creases brush
2. Select Pattern option
3. Create a new tag "blah", select that tag
4. Change any brush setting
5. Brush no longer has intended pattern
Comment 15 Halla Rempt 2021-03-25 14:34:47 UTC
* in master, I don't get the problem with the brush tip anymore.
* but I do get the issue with the patterns. 

I'm not quite sure how to avoid that, though, since the brush preset gets created from everything that's in the brush editor, and if you select a tag that doesn't contain a pattern, then there's no pattern set for that preset.
Comment 16 Halla Rempt 2021-04-09 13:57:19 UTC
I'm sorry, but I'm going to have to set this to wontfix: after thinking about it, there is no solution except hiding the tag functionality completely. The brush editor defines the brush from all the currently selected options, and if an option is hidden then it cannot be selected in the editor.