Bug 347949 - plasma panel does not set window size hints when panel is on right screen edge
Summary: plasma panel does not set window size hints when panel is on right screen edge
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Panel (show other bugs)
Version: 5.3.0
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-19 14:08 UTC by Diggory Hardy
Modified: 2018-03-02 20:11 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Diggory Hardy 2015-05-19 14:08:59 UTC
After chatting with Mr Grässlin about an issue, he noted a likely cause:

1) Window sizing hints are not set by a panel on the right screen edge. Martin's comments:
[14:39] <mgraesslin> QRect::right()
[14:40] <mgraesslin> "Note that for historical reasons this function returns left() + width() - 1; use x() + width() to retrieve the true x-coordinate."
[14:40] <mgraesslin> so the strut is not set correctly if it's on the right edge

The symptom: when the panel is on the right screen edge, a maximised window either covers or goes under the panel, instead of stopping short.

xprop on the panel (right screen edge): https://paste.kde.org/ptmna4ijh#line-55
(bottom edge): https://paste.kde.org/py7owqmsu#line-7

When the panel is on another screen edge, it appears that sizing hints are not absent but are incorrect (due to QT_DEVICE_PIXEL_RATIO=2, dimensions in the panel size hint are about half of what they actually are).

Reproducible: Always
Comment 1 Marco Martin 2015-05-20 09:49:05 UTC
as far i know struts can't be set on screen edges between two screens as it would break multiscreen
Comment 2 Diggory Hardy 2015-05-20 10:44:46 UTC
What's that got to do with it? In my case this is a single-screen set-up, and in any case there are no limits as to screen edges another screen may be attached to.
Comment 3 Marco Martin 2016-11-07 18:22:31 UTC
this issue has been recently fixed, now struts in between screens are respected
Comment 4 Alexander Mentyu 2018-03-02 13:06:00 UTC
is this issue could be safely closed?
Comment 5 Diggory Hardy 2018-03-02 14:53:45 UTC
I would guess so.