Bug 347777 - Random Offset is not saved in the brush preset
Summary: Random Offset is not saved in the brush preset
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Brush engines (other bugs)
Version First Reported In: 2.9.4
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-16 00:41 UTC by kaerhon
Modified: 2016-05-11 12:01 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
The Random Offset option wasn't being read from the saved preset. This fixes that (940 bytes, patch)
2015-07-29 18:02 UTC, Mohit Goyal
Details

Note You need to log in before you can comment on or make changes to this bug.
Description kaerhon 2015-05-16 00:41:50 UTC
The random offset checkboxes can't be saved in the brush preset : after closing and reopening krita, they are unchecked again, so it must be done in each session, instead of still being checked.

Reproducible: Always

Steps to Reproduce:
1.Check "Random Offset" checkboxes in a brush that uses a pattern texture
2.Save the preset with these boxes checked
3.Close Krita
4.Open Krita again
5.Chose the brush and see its texture settings
6.The "random offset" checkboxes are unchecked

Actual Results:  
The Random offset option isn't saved in the preset.

Expected Results:  
The Random offset option should be saved in the preset, as any brush option.

I'm running krita 2.9.4 on a Lubuntu (LXDE) machine
Comment 1 mvowada 2015-06-27 11:55:21 UTC
Confirming, this happens also with the latest Krita: 2.9.5 (git 9fe0557) - Ubuntu 14.04
Comment 2 Mohit Goyal 2015-07-02 05:10:36 UTC
Hi,
I looked into the code and found that Random offset is by default not saved as a preset property. Rather, it is used separately. I'll look into it and come up with a patch.
Comment 3 Mohit Goyal 2015-07-29 18:02:49 UTC
Created attachment 93795 [details]
The Random Offset option wasn't being read from the saved preset. This fixes that
Comment 4 wolthera 2016-05-11 12:01:08 UTC
Git commit 102ba3d9d24c2fb3d31db536d379313ee5dc6ade by Wolthera van Hovell tot Westerflier.
Committed on 11/05/2016 at 11:59.
Pushed by woltherav into branch 'master'.

So, the offset was stored but not read... Of course, when I check the bug,
turns out mohit had already made this patch, and I feel a little silly now.
Ah well, bug fixed, yay!

M  +2    -0    plugins/paintops/libpaintop/kis_texture_option.cpp

http://commits.kde.org/krita/102ba3d9d24c2fb3d31db536d379313ee5dc6ade