Bug 347621 - G'MIC "favourite" feature is missing
Summary: G'MIC "favourite" feature is missing
Status: RESOLVED UNMAINTAINED
Alias: None
Product: krita
Classification: Applications
Component: G'Mic for Krita (show other bugs)
Version: 2.9.4
Platform: Arch Linux Linux
: NOR wishlist
Target Milestone: ---
Assignee: LukasT
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-12 16:25 UTC by Jonathan Ringstad
Modified: 2017-06-24 18:03 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Ringstad 2015-05-12 16:25:43 UTC
A few of the G'MIC filters mention in their description that you can "favourite" a filter (e.g. the "Color > Curves [interactive]" filter instructs the user to "press the 'Add to Faves' button), but this functionality seems to be missing in krita.

Having it would be nice, as it's a useful feature (e.g. for filters where you need to punch in many values every time you want to use it) and would fix the confusing/incorrect instructions given by those filters.

Reproducible: Always
Comment 1 Halla Rempt 2015-05-12 18:32:59 UTC
Well, it's not g'mic feature, it's a feature in g'mic's Gimp plugin, with which we don't actually share any code. I'm sure there are other things that are in that plugin that aren't in Krita's. It's a bit sloppy for G'Mic to actually mention that sort of thing in the descriptions...
Comment 2 David Tschumperlé 2015-05-13 11:55:01 UTC
"It's a bit sloppy for G'Mic to actually mention that sort of thing in the descriptions..."

Wrong IMHO. The filters definition file used by the Krita plug-in is actually the one that has been written *specifically* for the GIMP plug-in. I've already told Lukas that it could be perhaps better to have your own filters definition file specifically for Krita instead (using tags like #@krita instead of #@gimp to define the filters). But it would mean also more work to maintain the list, particularly when there are updates.
Comment 3 LukasT 2015-05-22 13:42:45 UTC
> But it would mean also more work to maintain the list, particularly when there are 
> updates.

Yes, I don't think we can handle maintenance of the filter definitions. It generates work we can spend on more important things.

We need to find some long-term solution, maintaining own filter definition is not the way in my opinion.

Favorite presets feature will be implemented  in Krita for G'Mic!
Comment 4 Halla Rempt 2016-01-24 15:24:36 UTC
WISHGROUP: Larger Usability Fixes

Okay...  Lukas, can you please pick up this issue?
Comment 5 Halla Rempt 2017-06-24 18:03:59 UTC
We've just replaced our own gmic dialog with a plugin that communicates with the official gmic-qt plugin (which still needs to be released with our integration code, but it's already been merged), so we can close all current g'mic bugs.