Bug 347591 - Icons are way too small when in vertical panel
Summary: Icons are way too small when in vertical panel
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Icons-only Task Manager (show other bugs)
Version: 5.2.2
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Eike Hein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-12 09:59 UTC by davidebasilio
Modified: 2015-12-04 20:22 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Example of the issue (8.07 KB, image/png)
2015-05-12 09:59 UTC, davidebasilio 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description davidebasilio 2015-05-12 09:59:01 UTC 
Task icons are too small when used in a vertical panel (will attach screenshot).

Reproducible: Always

Steps to Reproduce:
1. Put icons-only task manager in vertical panel
2.
3.

Actual Results:  
Icons are minuscule.

Expected Results:  
Icons are of the right size.
Comment 1 davidebasilio 2015-05-12 09:59:36 UTC 
Created attachment 92554 [details]
Example of the issue
Comment 2 Eike Hein 2015-05-13 20:51:17 UTC 
Git commit 861ef07eb12a285b3a89e4bb8583ed6def0cb47f by Eike Hein.
Committed on 13/05/2015 at 20:48.
Pushed by hein into branch 'master'.

Fix vertical scaling having gotten out of sync with horizontal scaling.

This needs Marco's pending patch to fix the panel view's margin scaling
for vertical margins to do much. Marco, please CCBUG 347591 when you
push it.
CCMAIL:notmart@gmail.com

Unfortunately even with both patches bug 347591 isn't fixed; for as yet
unknown reasons the margins of the frame element are a third bigger on
the vertical than the horizontal, even though it's not showing as such
in the SVG.

M  +15   -7    applets/taskmanager/package/contents/ui/Task.qml

http://commits.kde.org/plasma-desktop/861ef07eb12a285b3a89e4bb8583ed6def0cb47f
Comment 3 Eike Hein 2015-05-15 01:16:14 UTC 
Marco unfortunately forgot to CCBUG: http://commits.kde.org/plasma-desktop/262ecde12d4881f005c9be8fc08aae4a49ba8c71
Comment 4 Andrew Chen 2015-11-30 02:13:12 UTC 
This seems to be fixed in 5.4.3, as I could not reproduce the issue.
Comment 5 Martin Klapetek 2015-12-04 20:22:28 UTC 
Following the last comment, closing as fixed.

If you can reproduce with Plasma 5.5, please reopen this report.

Thanks.