Bug 347533 - Brigthtness Curves Make incorrect Color
Summary: Brigthtness Curves Make incorrect Color
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Filters (other bugs)
Version First Reported In: 2.9.2
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-10 21:31 UTC by Paul Geraskin
Modified: 2016-05-11 12:09 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Geraskin 2015-05-10 21:31:01 UTC
Hi.

Brigthtness Curves Make incorrect Color.
In my test it must be black if i muve right point to the bottom.

Here is screenshot: http://i.imgur.com/USUPUk5.png
Here is the file: https://dl.dropboxusercontent.com/u/26887202/Krita/test_curve.psd
RGB channels must become 000 values.
Comment 1 Paul Geraskin 2015-05-10 21:33:11 UTC
Also, it's good to check RGBA Curves filter too. Possibly it's bugged too.
Comment 2 Halla Rempt 2015-05-15 11:09:01 UTC
The Krita color curves dialog makes everything black -- though we need an option there to adjust RGB channels in one go, instead of every channel separately.

There is no brightness/contrast curves dialog in Photoshop or Gimp, and Gimp's B&C slider dialog gives a different result from Photoshop's B&C slider dialog. Gimp makes everything gray if I move both sliders to the left-most position, Photoshop makes everything black.

In Krita we don't do the calculations ourselves: we pass the curve to lcms and lcms does the adjustments. lcms goes through lab to to determine brightness/contrast, and it's likely that there is some rounding involved. I don't know whether we can actually fix this in Krita, or whether we need to refer it to Marti.
Comment 3 Paul Geraskin 2015-05-15 11:20:30 UTC
Guys. This is color correction. This is basic of this.
We really need to fix it.

Gimp and PS are ok in this area of curves correction.
Here is just the same result from Gimp http://i.imgur.com/F0PlPL4.png

Possibly it's time to rewrite RGBA and Brightnes/Contrast curves into one good curves tool? Like PS/Gimp/Natron have.
Comment 4 wolthera 2016-05-11 12:09:08 UTC
this was resolved with rgba curve.