Gravatar is used by many applications on the internet to display an Avatar based on the email address of the sender. See https://en.gravatar.com/site/implement/ It would be nice if KAddressBook (and KMail too, should I make a new wishlist item for that?) could pull the Gravatar for contacts I've saved. Reproducible: Always
Do you have an example for it ? a screenshot etc ?
On May 9, 2015 06:37:37 AM you wrote: > https://bugs.kde.org/show_bug.cgi?id=347441 > > Laurent Montel <montel@kde.org> changed: > > What |Removed |Added > ---------------------------------------------------------------------------- > CC| |montel@kde.org > > --- Comment #1 from Laurent Montel <montel@kde.org> --- > Do you have an example for it ? > a screenshot etc ? > > Hi Laurent, The image provided in the link below is a capture of my viewing your email. The silhouette of a person in the top-left corner can be modified by manually providing an Avatar; I'd like to be able to turn on support for Gravatar so that the image is provided based on the email address of the sender. If you had a Gravatar, you could configure your email address with an image and I would see that in my mail messages, and in my address book. The user would have to be connected at the time to see them, but Gravatars are commonplace nowadays on multiple sites I use (Trello, RubyGems.org, WordPress) throughout the day. https://dl.dropboxusercontent.com/u/1422687/gravatar_wishlist_request.png
Kaddressbook has support for url but doesn't have widget for select it... Ok I will look at it.
Git commit efd54e9bf585cd278b39341e775f964d2f1e9043 by Montel Laurent. Committed on 11/05/2015 at 06:35. Pushed by mlaurent into branch 'KDE/4.14'. Start to fix gravatar support M +7 -0 kaddressbook/CMakeLists.txt A +10 -0 kaddressbook/gravatar/autotests/CMakeLists.txt A +35 -0 kaddressbook/gravatar/autotests/gravatarcreatejobtest.cpp [License: GPL (v2+)] A +35 -0 kaddressbook/gravatar/autotests/gravatarcreatejobtest.h [License: GPL (v2+)] A +35 -0 kaddressbook/gravatar/autotests/gravatarupdatejobtest.cpp [License: GPL (v2+)] A +35 -0 kaddressbook/gravatar/autotests/gravatarupdatejobtest.h [License: GPL (v2+)] A +40 -0 kaddressbook/gravatar/gravatarcreatejob.cpp [License: GPL (v2+)] A +39 -0 kaddressbook/gravatar/gravatarcreatejob.h [License: GPL (v2+)] A +41 -0 kaddressbook/gravatar/gravatarupdatejob.cpp [License: GPL (v2+)] A +39 -0 kaddressbook/gravatar/gravatarupdatejob.h [License: GPL (v2+)] http://commits.kde.org/kdepim/efd54e9bf585cd278b39341e775f964d2f1e9043
I started to look at how to implement it. It will finish for kf5 I think. I will continue to implement it.
Git commit 70c9120e520bede0dcec386c98aeab44e4b62a3e by Montel Laurent. Committed on 12/05/2015 at 11:28. Pushed by mlaurent into branch 'KDE/4.14'. Show gravatar in header It added kmail gravatar support I will add more gravatar support in kaddressbook after that M +37 -10 messageviewer/header/contactdisplaymessagememento.cpp M +11 -3 messageviewer/header/contactdisplaymessagememento.h M +15 -1 messageviewer/header/headerstyle_util.cpp M +1 -1 messageviewer/settings/messageviewer.kcfg.cmake A +7 -0 pimcommon/gravatar/autotests/gravatardownloadpixmapdialogtest.cpp [License: UNKNOWN] * A +17 -0 pimcommon/gravatar/autotests/gravatardownloadpixmapdialogtest.h [License: UNKNOWN] * A +7 -0 pimcommon/gravatar/widgets/gravatardownloadpixmapdialog.cpp [License: UNKNOWN] * A +11 -0 pimcommon/gravatar/widgets/gravatardownloadpixmapdialog.h [License: UNKNOWN] * The files marked with a * at the end have a non valid license. Please read: http://techbase.kde.org/Policies/Licensing_Policy and use the headers which are listed at that page. http://commits.kde.org/kdepim/70c9120e520bede0dcec386c98aeab44e4b62a3e
Now we have a cache for storing gravatar. I continue to implement support for kaddressbook.
Disclaimer: I'm not yet on KF5 (or git...), therefore I haven't checked this implementation. While it's surely a very nice feature, we mustn't forget privacy issues. By quickly scanning through the two commits above I see you check if GravatarSupport is enabled in GlobalSettings. But not knowing the code I'm not sure if this is a user set-able entry and/or if it's set by default. I'd expect many people not being happy if KAddressBook or KMail sends their (hashed) contacts to a third party service on the internet without asking first. So should this be the case, I'd propose adding some KCM or at least local configuration option to _manually_ enable this (could be proposed in a popup if it's too hidden otherwise). If you already thought about that and implemented it (somewhere else) I'm glad to see KDEPIM gaining more nice features and thank you for your great work :)
We can configure it of course :) End user can disable/enable it.
I look forward to using this new feature Laurent, do you know specifically which version numbers this will be available in?
(In reply to Robert Charbonneau from comment #10) > I look forward to using this new feature Laurent, do you know specifically > which version numbers this will be available in? You can see it in kmail 4.14.9 For kaddressbook it will activate in kf5
(In reply to Laurent Montel from comment #11) > You can see it in kmail 4.14.9 Oh, I just checked with wireshark and saw it's already active, indeed. This means KMail is leaking the mail hashes of my communication partners unencrypted over the net to a third party. So I just wanted to make sure that the configurability is not just a KAddressbook thing but system wide (KDEPIM wide). I hope I'm not too annoying, but such an option (by default off) in KMail 4.* would also be important. As a proposal: The optimal solution - IMHO - would be to enable it only for certain groups of contacts (like only check for contacts in the friends, collegues or unknown group), addressbooks (only for my private carddav or only the companies LDAP), - in the case of KMail - only for certain e-mail-addresses (like only my gmail-address, not for the work one) or mail-accounts (only for mails downloaded from/stored on the gmail-account, not my private server at home). So many possibilities ;-) Of course these options are a lot of work - so just deactivating it in total would already be helpful. These would just be an awesome improvement to make it much more useful in the long run! I hope you don't see this as overly negative feedback and understand why this could be very important for some people. So, let me also thank you again for the nice idea!
(In reply to OlafLostViking from comment #12) > (In reply to Laurent Montel from comment #11) > > You can see it in kmail 4.14.9 > > Oh, I just checked with wireshark and saw it's already active, indeed. This > means KMail is leaking the mail hashes of my communication partners > unencrypted over the net to a third party. So I just wanted to make sure > that the configurability is not just a KAddressbook thing but system wide > (KDEPIM wide). I hope I'm not too annoying, but such an option (by default > off) in KMail 4.* would also be important. for kmail4 we can't disable it, as we released last version. But ok for kf5 I will disable it by default. > > As a proposal: The optimal solution - IMHO - would be to enable it only for > certain groups of contacts (like only check for contacts in the friends, > collegues or unknown group), addressbooks (only for my private carddav or > only the companies LDAP), - in the case of KMail - only for certain > e-mail-addresses (like only my gmail-address, not for the work one) or > mail-accounts (only for mails downloaded from/stored on the gmail-account, > not my private server at home). So many possibilities ;-) Indeed it will good but very hard for enduser to configure it for specific email address. But I will investigate how to improve it. > > Of course these options are a lot of work - so just deactivating it in total > would already be helpful. These would just be an awesome improvement to make > it much more useful in the long run! > > I hope you don't see this as overly negative feedback and understand why > this could be very important for some people. So, let me also thank you > again for the nice idea! thanks for feedback.
Git commit 2cd9760b926386d1d755999590be50c5868e168a by Montel Laurent. Committed on 03/07/2015 at 11:59. Pushed by mlaurent into branch 'master'. Disable gravatar by default M +1 -1 messageviewer/settings/messageviewer.kcfg.cmake http://commits.kde.org/kdepim/2cd9760b926386d1d755999590be50c5868e168a
Now kaddressbook gravatar support is implement completly in 5.1
Git commit e98f350474c9a66f829fde111d2482cf256b0250 by Montel Laurent. Committed on 31/07/2015 at 11:55. Pushed by mlaurent into branch 'master'. Fix Bug 347441 - KAddressBook Gravatar Support FIXED-IN: 15.12 M +2 -0 kaddressbook/gravatar/autotests/gravatarupdatedialogtest.cpp M +34 -3 kaddressbook/gravatar/widgets/gravatarupdatedialog.cpp M +8 -1 kaddressbook/gravatar/widgets/gravatarupdatedialog.h M +3 -2 kaddressbook/gravatar/widgets/gravatarupdatewidget.cpp M +1 -0 kaddressbook/gravatar/widgets/gravatarupdatewidget.h M +21 -1 kaddressbook/mainwidget.cpp M +1 -0 kaddressbook/mainwidget.h http://commits.kde.org/kdepim/e98f350474c9a66f829fde111d2482cf256b0250