Bug 347332 - New window don't get actions from view plugins
Summary: New window don't get actions from view plugins
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: General (show other bugs)
Version: git master (please specify the git hash!)
Platform: Compiled Sources Linux
: NOR critical
Target Milestone: ---
Assignee: Halla Rempt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-06 17:59 UTC by Cyrille Berger
Modified: 2016-03-20 09:47 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Cyrille Berger 2015-05-06 17:59:52 UTC
View plugins are only accessible from the first opened window.

Reproducible: Always

Steps to Reproduce:
To reproduce:
1. Window > New Window

Actual Results:  
In the new window, view plugin actions are not visible. For instance, tools > recording, macros and Filter > gmic, and many entries in Layer...

Expected Results:  
Access to those menu entries in the new window.
Comment 1 Halla Rempt 2015-05-08 18:57:23 UTC
Hm, I'm not sure what's up -- I should look into this. In principle, all actions need to be defined in .action files. Not just in cpp files. Those get loaded by KisPart::loadActions, so they should all be around even when no document is opened, and should be available. But there's obviously a bug somewhere, see also the bugs about not being able to add the zoom actions to the toolbar.
Comment 2 Halla Rempt 2016-03-19 15:15:28 UTC
And whyever did I not confirm this bug. I guess because May was kickstarter month and I was too busy.
Comment 3 Halla Rempt 2016-03-20 09:47:37 UTC
Git commit e237e0e606223733631b8e23658926a6ee13b455 by Boudewijn Rempt.
Committed on 20/03/2016 at 09:05.
Pushed by rempt into branch 'master'.

Most plugins should be loaded only once, but the KritaView type
plugins need to be loaded for every Window.

M  +2    -2    libs/koplugin/KoPluginLoader.cpp
M  +2    -1    libs/koplugin/KoPluginLoader.h
M  +2    -1    libs/ui/KisMainWindow.cpp

http://commits.kde.org/krita/e237e0e606223733631b8e23658926a6ee13b455