Bug 347212 - Show desktop hides the panel
Summary: Show desktop hides the panel
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: core (show other bugs)
Version: 5.3.0
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
: 348467 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-05-05 08:45 UTC by Guido
Modified: 2015-05-31 19:07 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.3.1
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Guido 2015-05-05 08:45:00 UTC
Clicking on the show desktop icon in the panel, all windows disappears, also the panel itself

Reproducible: Always

Steps to Reproduce:
1. click on show desktop


Actual Results:  
All windows disappear (OK)
The panel disappears (BAD)

Expected Results:  
All windows disappear 
The panel doesn't disappear

The bug is present whatever show-desktop effect is selected.
Comment 1 Martin Flöser 2015-05-05 09:10:49 UTC

*** This bug has been marked as a duplicate of bug 346837 ***
Comment 2 Thomas Lübking 2015-05-05 09:16:52 UTC
Currently intended behavior (but not undiscussed, see linked bugs)

We need to disassemble the bug reg. reports because there're
a) actual implementation bugs
b) worries about the "behavior" of the plasmoid trigger (bug #346933)
c) concerns reg. the general panel stacking(?) (ie. whether they should generally be kept above the desktop or only opt into this)

=> please select a, b or c for you :-)
Comment 3 Guido 2015-05-05 10:43:01 UTC
I dont understand the difference between b) and c), btw I would the old behaviour of "show desktop" :)
Comment 4 Thomas Lübking 2015-05-05 10:55:41 UTC
If the only problem is that the plasmoid isn't accessible while showing the desktop, possible solutions would be to have it keep *ITS* panel (but not others) on top of the desktop or place a copy of itself onto the desktop etc.
It does not imply the requirement to keep *ANY* panel on top of the desktop.

This item (minus the panel situation!!!) is subject to flame since 2003 and we ultimately decided to perform a clean split between the fdo compliant "show desktop" (that does not minimize as implemetation detail to avoid any confusion) and a proprietary "minimize all" solution to end this - so it's not gonna restore ;-)
Comment 5 Guido 2015-05-05 11:11:46 UTC
No one in real word cares this "flame".
Comment 6 Thomas Lübking 2015-05-05 15:26:06 UTC
KWin devs do live in the real world, and telling the 100th time "show desktop is not minimize all and you actually wanted to use another virtual desktop itfp" to be countered by completely uninformed "but i want *this* to be *that* - i don't want to use *that* instead" is incredibly annoying.

Unless you volunteer to handle those discussions, you'll have to accept that *we* care about this flame and chose to cut it down by leaving no trail of ambiguity.
Comment 7 Thomas Lübking 2015-05-19 21:13:01 UTC
Git commit f3b69b0ed0d3fa863ed4b2233ac5ce6c5fcdd9c3 by Thomas Lübking.
Committed on 19/05/2015 at 20:01.
Pushed by luebking into branch 'Plasma/5.3'.

Showing Desktop: keep docks visible

REVIEW: 123783
Related: bug 346933, bug 346837
FIXED-IN: 5.3.1

M  +7    -0    layers.cpp
M  +9    -5    workspace.cpp

http://commits.kde.org/kwin/f3b69b0ed0d3fa863ed4b2233ac5ce6c5fcdd9c3
Comment 8 Thomas Lübking 2015-05-19 21:13:02 UTC
Git commit a16a489a43aef03e198630f80d8236b56052b6f9 by Thomas Lübking.
Committed on 19/05/2015 at 20:06.
Pushed by luebking into branch 'Plasma/5.3'.

Show Desktop: keep desktop group visible

Windows that "belong" to the desktop are
kept visible and do no break the state on
activation/mapping

REVIEW: 123783
Related: bug 346837, bug 346933

M  +6    -0    layers.cpp
M  +3    -0    workspace.cpp

http://commits.kde.org/kwin/a16a489a43aef03e198630f80d8236b56052b6f9
Comment 9 Thomas Lübking 2015-05-19 21:16:33 UTC
Git commit eb789e43e317fbb25fbd1f51d0edf9800f8c002a by Thomas Lübking.
Committed on 19/05/2015 at 20:09.
Pushed by luebking into branch 'Plasma/5.3'.

Show Desktop: activateNextClient prefers desktop

othrwise closing a keepabove or desktop group
window would activate some random window and break
the state as a side-effect

REVIEW: 123783
Related: bug 346837, bug 346933

M  +5    -2    activation.cpp

http://commits.kde.org/kwin/eb789e43e317fbb25fbd1f51d0edf9800f8c002a
Comment 10 Thomas Lübking 2015-05-19 21:16:34 UTC
Git commit 43e3b7db285c48efb25966334262d0e80190fd9e by Thomas Lübking.
Committed on 19/05/2015 at 20:07.
Pushed by luebking into branch 'Plasma/5.3'.

Show Desktop: break state with activation (only)

... not them becoming visible.
Latter doesn't work for most cases (unminimizing)
for obvious reasons (they're not minimized) and
when a new window is mapped, the focus stealing
prevention seems a good filter
(if it's not good enough to gain the focus,
it's not good enough to break the state either)

REVIEW: 123783
Related: bug 346837, bug 346933

M  +12   -16   client.cpp
M  +0    -1    client.h
M  +0    -2    manage.cpp

http://commits.kde.org/kwin/43e3b7db285c48efb25966334262d0e80190fd9e
Comment 11 David Edmundson 2015-05-31 19:07:52 UTC
*** Bug 348467 has been marked as a duplicate of this bug. ***