Bug 347131 - battery Tooltip doesn't update text when AC Adapter is plugged in
Summary: battery Tooltip doesn't update text when AC Adapter is plugged in
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Power and Battery widget (show other bugs)
Version: 5.13.5
Platform: Arch Linux Linux
: NOR normal
Target Milestone: 1.0
Assignee: Kai Uwe Broulik
URL:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2015-05-03 23:18 UTC by Simon Solinas
Modified: 2020-05-20 21:43 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.3.0
Sentry Crash Report:


Attachments
a problem's screenshot (1.59 MB, image/png)
2015-05-03 23:25 UTC, Simon Solinas
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Solinas 2015-05-03 23:18:28 UTC
Plasma.battery Tooltip doesn't update text when AC Adapter is plugged in, it always shows "Fully Charged" even if it's not fully charged.

Reproducible: Always

Steps to Reproduce:
1.move mouse over battery plasmoid
2. wait for popup
3. read information from poup

Actual Results:  
Fully Charged

Expected Results:  
%1% Battery Remaining
Comment 1 Simon Solinas 2015-05-03 23:25:04 UTC
Created attachment 92402 [details]
a problem's screenshot
Comment 2 Kai Uwe Broulik 2015-05-04 18:25:42 UTC
Thanks for your detailed bug report!

Previously Solid could not handle the "Fully Charged" state and we used the "NoCharge" for that as well, so perhaps we forgot to adjust that in some place. However, I don't find where that could be. The PM dataengine (which takes Solid data and feeds it into battery monitor) handles both states, batterymonitor's tooltip does not, but then its "else" branch ("xx% remaining") would be entered.
Could you, when this happens, provide the output of "upower -d" (the raw data Solid uses) and check in plasmaengineexplorer (part of "plasmate") in the powermanagement dataengine?
Comment 3 Simon Solinas 2015-05-04 19:47:56 UTC
Sure when that happens I'll do.
With plasma 5.2.x the only way to ensure that the tooltip works was edit in logic.js the function updateTooltip(remainingTime){...} in this way

if (batteries.allCharged) {
        batteries.tooltipImage = "battery-100";
       // batteries.tooltipMainText = i18n("Fully Charged");
        batteries.tooltipMainText = i18n("%1% Battery Remaining", batteries.cumulativePercent);
    }
Comment 4 Kai Uwe Broulik 2015-05-04 21:06:37 UTC
Ah, I changed the handling of the batteries a bit in 5.3 (we no longer calculate the "allCharged" thing ourself but just ask upower which as you showed reports correct data), so it should properly fall back to "%1% Remaining" now when the battery is neither fully charged nor charging. Feel free to re-open if the issue persists in Plasma 5.3. Thanks!
Comment 5 Simon Solinas 2015-05-04 21:33:10 UTC
but the bug reported is related to palsma 5.3.0, so it's not resolved.
Comment 6 Kai Uwe Broulik 2015-05-04 21:35:21 UTC
Oh, okay, I thought because your comment said 5.2.x, reopening.
Comment 7 Kai Uwe Broulik 2015-08-05 14:08:00 UTC
Can you try whether http://quickgit.kde.org/?p=plasma-workspace.git&a=commit&h=33730d9094d2c170745a697fd24bf8fe0fd632d5 fixed this?
Comment 8 Simon Solinas 2015-08-05 18:19:39 UTC
Unfortunately not.
Comment 9 Kai Uwe Broulik 2016-03-09 17:13:53 UTC
And this? https://quickgit.kde.org/?p=plasma-workspace.git&a=commit&h=a1e37a80d70510d743e681d48afb73f9ba6ea3fb

Maybe I forgot a manual update call somewhere which should work this way now. If that also doesn't work, the problem lies elsewhere.
Comment 10 Simon Solinas 2016-03-10 12:56:56 UTC
Doesn't work yet.
Comment 11 Andrew Crouthamel 2018-09-26 22:06:21 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days, the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information.

For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please set the bug status as REPORTED so that the KDE team knows that the bug is ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 12 Simon Solinas 2018-09-27 05:25:50 UTC
Nothing os changed, the bug it's still in 5.13.5.
Comment 13 Nate Graham 2020-05-20 21:43:32 UTC
This was fixed recently!