Bug 346718 - Ill sized TextArea when a font other then Oxygen is chosen
Summary: Ill sized TextArea when a font other then Oxygen is chosen
Status: RESOLVED FIXED
Alias: None
Product: libplasma
Classification: Frameworks and Libraries
Component: components (other bugs)
Version First Reported In: 5.1.0
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-26 13:53 UTC by Mark
Modified: 2020-11-24 19:03 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Oxygen font (66.24 KB, image/png)
2015-04-26 13:54 UTC, Mark
Details
Bitstream Vera (64.38 KB, image/png)
2015-04-26 13:55 UTC, Mark
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mark 2015-04-26 13:53:38 UTC
Hi,

Plasma 5 defaults to the Oxygen font. However, i find the Oxygen font to be very poor. It's not sharp, makes all text look fuzzy... I'm sure that will all get resolved in time, but till that happens i stay with bitstream vera or the libration fonts.

Choosing another font has a little nasty side effect on the plasma text input components. They look off. You can see the results in the screenshots. One is with Oxygen set as the font, the other is with Bitstream Vera as font.

A partial fix is modifying the TextFieldStyle.qml component. It currently does this in onCompleted:
        Component.onCompleted: {
            root.padding.left = base.margins.left
            root.padding.top = base.margins.top
            //TODO: if QtControls gets a component for this, use it instead of this hardcoded heuristic
            root.padding.right = base.margins.right + (control.clearButtonShown ? Math.max(control.parent.height*0.8, units.iconSizes.small)+units.smallSpacing : 0)
            root.padding.bottom = base.margins.bottom
        }

If you remove the bottom and top padding rules, the font cursor is neatly in the middle again. But that still means that the entire font input area is still smaller (in height) then it would be with the oxygen font. I'm guessing the actual fix would be in either that file (since it looks fine without that style, but not oxygen like) or in how the implicit height and width is calculated.

Reproducible: Always
Comment 1 Mark 2015-04-26 13:54:34 UTC
Created attachment 92229 [details]
Oxygen font
Comment 2 Mark 2015-04-26 13:55:06 UTC
Created attachment 92230 [details]
Bitstream Vera
Comment 3 Nate Graham 2020-11-24 19:03:09 UTC
This is fixed now.