Bug 346646 - renaming works when downloading selected but settings are ignored when importing new ones only
Summary: renaming works when downloading selected but settings are ignored when import...
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: AdvancedRename-Import (show other bugs)
Version: 4.9.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-25 15:50 UTC by lig
Modified: 2017-08-17 06:46 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.13.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description lig 2015-04-25 15:50:40 UTC
Depending on the download mode (all, selected, new ones) only the renaming pattern is used or not. 

Reproducible: Always

Steps to Reproduce:
1. define renaming pattern 
2. download new images only
3.

Actual Results:  
renaming pattern not used

Expected Results:  
renaming pattern should be applied
Comment 1 Maik Qualmann 2015-04-27 16:40:56 UTC
Git commit 42838bc967a87638c7d76f87a4f44add99665d53 by Maik Qualmann.
Committed on 27/04/2015 at 16:32.
Pushed by mqualmann into branch 'master'.

blocking slotUpdateDownloadName() during the download of images
FIXED-IN: 4.10.0

M  +2    -1    NEWS
M  +5    -0    utilities/importui/main/importui.cpp

http://commits.kde.org/digikam/42838bc967a87638c7d76f87a4f44add99665d53
Comment 2 Maik Qualmann 2015-04-28 17:04:48 UTC
Git commit 9585ee545003a85c4b45c39bf30939634a40ce7d by Maik Qualmann.
Committed on 28/04/2015 at 17:01.
Pushed by mqualmann into branch 'master'.

remove unnecessary blockSignals() in the importui.cpp

M  +0    -3    utilities/importui/main/importui.cpp

http://commits.kde.org/digikam/9585ee545003a85c4b45c39bf30939634a40ce7d
Comment 3 caulier.gilles 2015-04-29 13:19:44 UTC
Git commit 336cb1696b45e1272b5c5e759f169f9bc48c740f by Gilles Caulier.
Committed on 29/04/2015 at 13:18.
Pushed by cgilles into branch 'frameworks'.

backport commits #42838bc967a87638c7d76f87a4f44add99665d53 and #9585ee545003a85c4b45c39bf30939634a40ce7d from git/master to frameworks branch

M  +5    -3    utilities/importui/main/importui.cpp

http://commits.kde.org/digikam/336cb1696b45e1272b5c5e759f169f9bc48c740f
Comment 4 lig 2015-05-18 19:42:27 UTC
I am now on digikam 4.10 - renaming does not work when downloading "new ones only"
Comment 5 Maik Qualmann 2015-05-18 19:55:22 UTC
Here not to reproduce. What renaming pattern use you?

Maik
Comment 6 lig 2015-05-18 19:59:41 UTC
I use  [date:"yyyy-MM-dd_hhmmss"], the correct folder yyyy-MM-dd is made in all cases by the way.
Comment 7 Maik Qualmann 2015-05-18 20:18:19 UTC
When the dialog box for selecting the target album is opened, the selected thumbnails are renamed properly in the background?

Maik
Comment 8 lig 2015-05-19 10:33:12 UTC
Sorry maybe I was not clear. My bug report relates to the import feature when a camera is connected via USB.

Renaming pattern is definded  [date:"yyyy-MM-dd_hhmmss"], pictures shall be put in date dependant folders yyyy-MM-dd

When importing (manually) selected pictures everything works, however when I select for downloading "new ones only" renaming pattern is not applied but pictures are placed in a fresh correctly named folder.

Renaming after importing works; that is what I do for correcting ;)
Comment 9 Maik Qualmann 2015-07-12 12:02:24 UTC
Git commit 72f5a20f563308706c3e6c859e7350fe7f293b3b by Maik Qualmann.
Committed on 12/07/2015 at 11:55.
Pushed by mqualmann into branch 'master'.

advanced rename from import window use now the file url to get the new file name

M  +32   -26   utilities/importui/main/importui.cpp

http://commits.kde.org/digikam/72f5a20f563308706c3e6c859e7350fe7f293b3b
Comment 10 Maik Qualmann 2015-07-12 21:27:13 UTC
Git commit 4bb43c170e97fad5ce965b54546cf1250855180d by Maik Qualmann.
Committed on 12/07/2015 at 21:25.
Pushed by mqualmann into branch 'master'.

optimizations for renaming in the Import window and start numbering from the camera working again

M  +0    -1    utilities/advancedrename/advancedrenamemanager.cpp
M  +43   -69   utilities/importui/main/importui.cpp
M  +2    -2    utilities/importui/main/importui.h

http://commits.kde.org/digikam/4bb43c170e97fad5ce965b54546cf1250855180d
Comment 11 caulier.gilles 2015-07-12 22:04:30 UTC
Git commit 01eac40e1c6b7b9b87b4db98485521b983f42728 by Gilles Caulier.
Committed on 12/07/2015 at 22:02.
Pushed by cgilles into branch 'frameworks'.

backport commit #72f5a20f563308706c3e6c859e7350fe7f293b3b from git/master to frameworks branch

M  +2    -0    utilities/advancedrename/parser/importrenameparser.cpp
M  +32   -32   utilities/importui/main/importui.cpp

http://commits.kde.org/digikam/01eac40e1c6b7b9b87b4db98485521b983f42728
Comment 12 Maik Qualmann 2015-07-13 21:04:34 UTC
Git commit 46a9e1a3f6a2d36e69fb0eb7c9ae74c047b3bf51 by Maik Qualmann.
Committed on 13/07/2015 at 21:01.
Pushed by mqualmann into branch 'master'.

optimizations for renaming in the Import window

M  +11   -12   utilities/importui/main/importui.cpp

http://commits.kde.org/digikam/46a9e1a3f6a2d36e69fb0eb7c9ae74c047b3bf51
Comment 13 Maik Qualmann 2015-07-14 20:48:10 UTC
Git commit ba745bd5289ebeee46d6379f0c821db1492fc00b by Maik Qualmann.
Committed on 14/07/2015 at 20:45.
Pushed by mqualmann into branch 'frameworks'.

backport commit #4bb43c170e97fad5ce965b54546cf1250855180d from git/master to frameworks branch

M  +57   -76   utilities/importui/main/importui.cpp
M  +2    -2    utilities/importui/main/importui.h

http://commits.kde.org/digikam/ba745bd5289ebeee46d6379f0c821db1492fc00b
Comment 14 Maik Qualmann 2015-08-11 17:23:10 UTC
digiKam 4.12.0 have been released.

Can you reproduce the problem with this release ?

Maik
Comment 15 Maik Qualmann 2015-08-16 18:47:17 UTC
Git commit 2cbd005028bd12d23bc5784ac4f6a4b95adf04b1 by Maik Qualmann.
Committed on 16/08/2015 at 18:36.
Pushed by mqualmann into branch 'master'.

Fix set new download name from import tool when use a default target album
Related: bug 350225
FIXED-IN: 4.13.0

M  +3    -1    NEWS
M  +14   -3    utilities/importui/main/importui.cpp

http://commits.kde.org/digikam/2cbd005028bd12d23bc5784ac4f6a4b95adf04b1
Comment 16 caulier.gilles 2015-08-18 20:59:34 UTC
Git commit 0e1dab213c77acd103f49a9afa6452d4226ffc66 by Gilles Caulier.
Committed on 18/08/2015 at 20:58.
Pushed by cgilles into branch 'frameworks'.

backport commit #2cbd005028bd12d23bc5784ac4f6a4 from git/master to frameworks branch
Related: bug 350225

M  +14   -5    utilities/importui/main/importui.cpp

http://commits.kde.org/digikam/0e1dab213c77acd103f49a9afa6452d4226ffc66
Comment 17 lig 2015-09-03 19:57:45 UTC
I am now on 4.12; problem is not solved.

Importing new pictures only still neglects the renaming pattern.

Georg
Comment 18 Maik Qualmann 2015-09-03 20:05:23 UTC
Yes, will be only fixed in digiKam 4.13.0. DigiKam 4.13.0 will be released soon.

Maik
Comment 19 lig 2015-09-15 16:56:59 UTC
On 4.13 it works fine.

Thanks,

Georg