346429 – kglobalaccel_x11.cpp has qDebug calls, should be qCDebug

Bug 346429 - kglobalaccel_x11.cpp has qDebug calls, should be qCDebug

Summary: kglobalaccel_x11.cpp has qDebug calls, should be qCDebug

Status:	RESOLVED FIXED

Alias:	None

Product:	frameworks-kglobalaccel
Classification:	Frameworks and Libraries
Component:	general (show other bugs)
Version:	unspecified
Platform:	Fedora RPMs Linux

Importance:	NOR normal
Target Milestone:	---
Assignee:	Martin Flöser

URL:
Keywords:

Depends on:
Blocks:

Reported:	2015-04-21 13:03 UTC by Marcin Juszkiewicz
Modified:	2015-04-22 09:03 UTC (History)
CC List:	3 users (show)

See Also:
Latest Commit:	http://commits.kde.org/kglobalaccel/8cc732ecc066b5250e501c85b7e2615d47c828ec
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.

Description Marcin Juszkiewicz 2015-04-21 13:03:35 UTC

Each time I use keyboard to do something KWin related it ends in system journal:

kwi 21 15:01:02 puchatek org.kde.kglobalaccel[1296]: Got XKeyPress event
kwi 21 15:01:02 puchatek org.kde.kglobalaccel[1296]: "Meta+2" = "Switch to Desktop 2"
kwi 21 15:01:07 puchatek org.kde.kglobalaccel[1296]: Got XKeyPress event
kwi 21 15:01:07 puchatek org.kde.kglobalaccel[1296]: "Meta+1" = "Switch to Desktop 1"
kwi 21 15:01:13 puchatek org.kde.kglobalaccel[1296]: Got XKeyPress event
kwi 21 15:01:13 puchatek org.kde.kglobalaccel[1296]: "Meta+2" = "Switch to Desktop 2"
kwi 21 15:01:26 puchatek org.kde.kglobalaccel[1296]: Got XKeyPress event
kwi 21 15:01:26 puchatek org.kde.kglobalaccel[1296]: "Alt+F3" = "Window Operations Menu"
kwi 21 15:01:27 puchatek org.kde.kglobalaccel[1296]: Got XKeyPress event
kwi 21 15:01:27 puchatek org.kde.kglobalaccel[1296]: "Meta+1" = "Switch to Desktop 1"

kdebugdialog and kdebugdialog5 have all debug output disabled so it should not happen

Reproducible: Always

Steps to Reproduce:
1. switch desktop by keyboard or use alt-f3 to open window menu


Actual Results:  
kwi 21 15:01:26 puchatek org.kde.kglobalaccel[1296]: Got XKeyPress event
kwi 21 15:01:26 puchatek org.kde.kglobalaccel[1296]: "Alt+F3" = "Window Operations Menu"
kwi 21 15:01:27 puchatek org.kde.kglobalaccel[1296]: Got XKeyPress event
kwi 21 15:01:27 puchatek org.kde.kglobalaccel[1296]: "Meta+1" = "Switch to Desktop 1"


Expected Results:  
no journal entries

Comment 1 Rex Dieter 2015-04-21 15:05:53 UTC

I'll have to check, but shouldn't qDebug be disabled in Release mode builds anyway?

Comment 2 Thomas Lübking 2015-04-21 15:10:39 UTC

Release: yes.
RelWithDebInfo: no.

Actually controlled by QT_NO_DEBUG_OUTPUT

Comment 3 Rex Dieter 2015-04-21 15:12:10 UTC

Oh, ok.  (I personally disagree with that, WithDebInfo should not be any different in this regard, IMHO)

Comment 4 Martin Flöser 2015-04-22 07:54:59 UTC

Review request created: https://git.reviewboard.kde.org/r/123463/

Comment 5 Martin Flöser 2015-04-22 09:03:11 UTC

Git commit 8cc732ecc066b5250e501c85b7e2615d47c828ec by Martin Gräßlin.
Committed on 22/04/2015 at 09:02.
Pushed by graesslin into branch 'master'.

Use categorized logging in runtime component
REVIEW: 123463

M  +1    -0    src/runtime/CMakeLists.txt
M  +8    -7    src/runtime/component.cpp
M  +4    -4    src/runtime/globalshortcut.cpp
M  +9    -8    src/runtime/globalshortcutsregistry.cpp
M  +14   -13   src/runtime/kglobalaccel_mac.cpp
M  +2    -1    src/runtime/kglobalaccel_win.cpp
M  +12   -11   src/runtime/kglobalaccel_x11.cpp
M  +16   -15   src/runtime/kglobalacceld.cpp
A  +21   -0    src/runtime/logging.cpp     [License: BSD]
A  +26   -0    src/runtime/logging_p.h     [License: BSD]
M  +2    -1    src/runtime/main.cpp

http://commits.kde.org/kglobalaccel/8cc732ecc066b5250e501c85b7e2615d47c828ec

Comment 6 Martin Flöser 2015-04-22 09:03:50 UTC

@Rex: it should be pretty save to pull the change into your distro packages.