The continuation of bug 339684. The screen could still be wider as seen in attached screenshots. It would be nice to scroll the song name if it does not fit. Reproducible: Always
Created attachment 91998 [details] too narrow in portrait mode
Created attachment 91999 [details] Here the width is OK in portrait mode
Created attachment 96599 [details] too wide left and right margins marked with red lines I marked too wide left and right margins with red lines. If left and right margins were narrower, then more text would fit to screen. As you can see, the song name does not fit completely.
Created attachment 96600 [details] patched This is how it looks when the following patch is applied: diff --git a/res/layout/mpris_control.xml b/res/layout/mpris_control.xml index daba05a..25961f8 100644 --- a/res/layout/mpris_control.xml +++ b/res/layout/mpris_control.xml @@ -7,9 +7,9 @@ android:layout_height="match_parent" android:id="@+id/mpris_control_view" android:gravity="center" - android:paddingLeft="60dip" + android:paddingLeft="5dip" android:paddingTop="5dip" - android:paddingRight="60dip" + android:paddingRight="5dip" android:paddingBottom="5dip"> <TextView
The latest git added scrolling the song name if it does not fit. But the margins could still be smaller. The following patch works OK on my phone and looks good: diff --git a/res/layout/mpris_control.xml b/res/layout/mpris_control.xml index 80143b1..782eb23 100644 --- a/res/layout/mpris_control.xml +++ b/res/layout/mpris_control.xml @@ -7,9 +7,9 @@ android:layout_height="match_parent" android:id="@+id/mpris_control_view" android:gravity="center" - android:paddingLeft="60dip" + android:paddingLeft="30dip" android:paddingTop="5dip" - android:paddingRight="60dip" + android:paddingRight="30dip" android:paddingBottom="5dip"> <TextView
Git commit 93522c9648333ad1a28ea3d80d6cf532990294d6 by Albert Vaca. Committed on 18/01/2016 at 10:30. Pushed by albertvaka into branch '0.9'. Made MPRIS interface wider M +2 -2 res/layout/mpris_control.xml http://commits.kde.org/kdeconnect-android/93522c9648333ad1a28ea3d80d6cf532990294d6
Done!
Git commit c647cbd93c498f9c0e415c1b3000a473fdfb510c by Albert Vaca. Committed on 18/01/2016 at 10:42. Pushed by albertvaka into branch 'master'. Made MPRIS interface wider M +2 -2 res/layout/mpris_control.xml http://commits.kde.org/kdeconnect-android/c647cbd93c498f9c0e415c1b3000a473fdfb510c