Bug 345980 - File name and other info lost from titlebar after image modification
Summary: File name and other info lost from titlebar after image modification
Status: RESOLVED FIXED
Alias: None
Product: gwenview
Classification: Applications
Component: general (show other bugs)
Version: 5.0.0
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Gwenview Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-08 12:11 UTC by Greg Lepore
Modified: 2017-12-17 07:25 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Three images showing bug occuring (56.46 KB, image/jpeg)
2015-04-08 12:12 UTC, Greg Lepore
Details
Image 2 (60.08 KB, image/jpeg)
2015-04-08 12:12 UTC, Greg Lepore
Details
Image 3 (56.93 KB, image/jpeg)
2015-04-08 12:13 UTC, Greg Lepore
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Greg Lepore 2015-04-08 12:11:27 UTC
When opening an image in Gwenview, the file name, dimensions, and zoom percentage are stated in the titlebar of the application. However, when the image is modified, the information is removed from the titlebar. When the image is saved, the information is still not present.

Reproducible: Always

Steps to Reproduce:
1. Open an image, observe the file information in the titlebar
2. Modify the image, the information is removed
3. Save the image, the information does not return

Actual Results:  
File information is removed upon modification

Expected Results:  
FIle information should be returned (with new values)
Comment 1 Greg Lepore 2015-04-08 12:12:42 UTC
Created attachment 91943 [details]
Three images showing bug occuring
Comment 2 Greg Lepore 2015-04-08 12:12:58 UTC
Created attachment 91944 [details]
Image 2
Comment 3 Greg Lepore 2015-04-08 12:13:13 UTC
Created attachment 91945 [details]
Image 3
Comment 4 Nate Graham 2017-09-09 03:31:49 UTC
*** Bug 364104 has been marked as a duplicate of this bug. ***
Comment 5 Nate Graham 2017-09-09 03:40:38 UTC

*** This bug has been marked as a duplicate of bug 249001 ***
Comment 6 null 2017-12-05 00:40:41 UTC
Bug 249001 is not a duplicate, because the duplicate is triggered by renaming and fixed by https://phabricator.kde.org/D9161, while here we modify an image (e.g. via cropping) which is still broken with the patch.
Comment 7 null 2017-12-17 07:25:55 UTC
Git commit 5a7d105ae9dead6214953bfcb3f184c0399be42b by Henrik Fehlauer, on behalf of Peter Mühlenpfordt.
Committed on 17/12/2017 at 07:25.
Pushed by rkflx into branch 'Applications/17.12'.

Update titlebar after image modification

Summary:
In some cases the titlebar information (filename, size, zoom) is lost after an image has been modified.
This patch fixes the caption update and thereby also the missing `*` on modified images.

Test Plan:
Case 1:
1. Open image in view mode, which fits in window (100% zoom)
2. Scale (Shift-R) or crop (Shift-C) image
-> Titlebar info is lost

Case 2:
1. Open big image in view mode, which is zoomed to fit in window
2. Scale image with Shift-R (do not save)
3. Go to another big image (zoomed to fit)
3. Scale image with Shift-R
-> Titlebar info is lost

Reviewers: rkflx

Reviewed By: rkflx

Subscribers: ngraham

Differential Revision: https://phabricator.kde.org/D9293

M  +9    -6    app/mainwindow.cpp
M  +1    -0    app/mainwindow.h

https://commits.kde.org/gwenview/5a7d105ae9dead6214953bfcb3f184c0399be42b