Bug 345741 - Unable to reorder entries in favorites menu after scrolling down
Summary: Unable to reorder entries in favorites menu after scrolling down
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Application Launcher (Kickoff) widget (other bugs)
Version First Reported In: 5.2.2
Platform: Arch Linux Linux
: NOR normal
Target Milestone: 1.0
Assignee: David Edmundson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-01 01:06 UTC by Jonathan Liu
Modified: 2016-08-02 07:14 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Liu 2015-04-01 01:06:48 UTC
I have many entries in the favorites menu. I can reorder the entries if the vertical scrollbar is at the top but if I scroll to the bottom of the favorites menu and try to reorder the items, it doesn't show a drop indicator for anywhere other than the end of the favorites list.

Reproducible: Always

Steps to Reproduce:
1. Add lots of applications to favorites such that less than half of the favorites are shown when you scroll to the top of the favorites menu list
2. Scroll to the bottom of the favorites list
3. Click and drag the 3rd-last item up one position

Actual Results:  
A drop indicator is only shown for the end of the list rather than the desired drop position and releasing the mouse moves the item to the end of the list.

Expected Results:  
A drop indicator is shown for the desired drop position and releasing the mouse moves the item to the desired position in the list.
Comment 1 Antonis G. 2015-04-04 13:45:46 UTC
Maybe it is same problem as bug 345864
Comment 2 David Edmundson 2015-04-06 22:04:47 UTC
Antonis, don't be afraid to mark things as duplicates. We can always un-duplicate things if we need to

*** This bug has been marked as a duplicate of bug 345864 ***
Comment 3 Jonathan Liu 2016-07-30 03:58:27 UTC
Patch submitted for review: https://phabricator.kde.org/D2310
Comment 4 Bhushan Shah 2016-08-02 07:14:11 UTC
Git commit ae319ac4fbe665d78dc963ffdadc0d71752876e3 by Bhushan Shah, on behalf of Jonathan Liu.
Committed on 02/08/2016 at 07:13.
Pushed by bshah into branch 'master'.

[Kickoff] Fix being unable to reorder entries in favorites menu after scrolling down

Summary:

Test Plan:
I have many entries in the favorites menu. I can reorder the entries if the vertical scrollbar is at the top but if I scroll to the bottom of the favorites menu and try to reorder the items, it doesn't show a drop indicator for anywhere other than the end of the favorites list.

Steps to Reproduce:
1. Add lots of applications to favorites such that less than half of the favorites are shown when you scroll to the top of the favorites menu list
2. Scroll to the bottom of the favorites list
3. Click and drag the 3rd-last item up one position

Reviewers: broulik, #plasma

Reviewed By: broulik, #plasma

Subscribers: broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D2310

M  +2    -1    applets/kickoff/package/contents/ui/FavoritesView.qml

http://commits.kde.org/plasma-desktop/ae319ac4fbe665d78dc963ffdadc0d71752876e3