Bug 345614 - Breeze window switcher shows all borders
Summary: Breeze window switcher shows all borders
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Global Theme packages (show other bugs)
Version: master
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-28 13:36 UTC by Mika Allan Rauhala
Modified: 2015-04-27 14:58 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Screenshot (black border added to top and left edge to highlight to problem) (68.07 KB, image/png)
2015-03-28 13:38 UTC, Mika Allan Rauhala
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mika Allan Rauhala 2015-03-28 13:36:41 UTC
The Breeze window switcher(Alt+Tab) (in plasma-workspace/lookandfeel/contents/windowswitcher) uses PlasmaCore.Dialog with location set to Floating. PlasmaCore.Dialog always shows all borders(left, right, top, bottom) when location == Floating. This looks ugly because the Breeze window switcher is in the left edge. Only right border should be shown.

So why not use LeftEdge as dialog location? Because it also uses a slide animation. And slide animation doesn't work nicely with window thumbnails(they don't move like rest of the window).

My ideas on how to fix this: Fix window thumbnails so they would work properly with slide animation and set dialog's location to LeftEdge. Or simply revert plasma-framework commit fc98e63 (always use all the borders for floating dialogs).

Reproducible: Always
Comment 1 Mika Allan Rauhala 2015-03-28 13:38:32 UTC
Created attachment 91792 [details]
Screenshot (black border added to top and left edge to highlight to problem)
Comment 2 David Edmundson 2015-04-26 11:34:53 UTC
Oh yeah, it's different from add widgets, and switch activities which is exactly what we want to avoid.

Thanks.
Comment 3 David Edmundson 2015-04-27 14:58:35 UTC
Git commit f0d0518a70417b35124c0089325b32a6e6bf8f5e by David Edmundson.
Committed on 27/04/2015 at 14:58.
Pushed by davidedmundson into branch 'Plasma/5.3'.

Match window switch dialog borders with addwidgets/switch activity
REVIEW: 123506

M  +1    -1    lookandfeel/contents/windowswitcher/WindowSwitcher.qml

http://commits.kde.org/plasma-workspace/f0d0518a70417b35124c0089325b32a6e6bf8f5e