Bug 345567 - crash when opening jpg with full exif data on OSX
Summary: crash when opening jpg with full exif data on OSX
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: File formats (show other bugs)
Version: 2.9.1
Platform: macOS (DMG) macOS
: NOR crash
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
: 348661 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-03-27 07:05 UTC by Roel
Modified: 2016-01-24 09:05 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Saved straight out of Photoshop CC 2014 as JPG (32.06 KB, image/jpeg)
2015-03-27 09:38 UTC, Roel
Details
Saved straight out of Photoshop CC 2014 as 'Save for WEB' JPG including All Exif (15.72 KB, image/jpeg)
2015-03-27 09:41 UTC, Roel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Roel 2015-03-27 07:05:31 UTC
On OSX, krita crashed every time when I'd open a JPG..
Did some testing:
Open JPG in Photoshop and selected save for web:
In EXIF selection:
NO EXIF  -> Loads OK in Krita
Only Copyright -> Loads OK in Krita
Only Copyright and contact info -> Loads OK in Krita
All Except Camera Info -> Krita crashes when opening this file
All -> Krita crashes when opening this file

Most modern JPG's have full exif info, so crashes are imminent
Thanks for looking into it


Reproducible: Always

Steps to Reproduce:
See details
Comment 1 Halla Rempt 2015-03-27 08:12:22 UTC
Hi Roel,

Thanks for your report. Can you attach the jpg file? I haven't encountered one with the problem. Though it might be OSX-specific of course, investigating the bug will be easier with a known-bad file.
Comment 2 Roel 2015-03-27 09:38:21 UTC
Created attachment 91769 [details]
Saved straight out of Photoshop CC 2014 as JPG

This file crashes my Krita on OSX
Comment 3 Roel 2015-03-27 09:41:09 UTC
Created attachment 91770 [details]
Saved straight out of Photoshop CC 2014 as 'Save for WEB' JPG including All Exif

This file loads OK in my Krita on OSX

I've opened both files in Hex editor to compare them.. only thing I can see is a different XMP version.. where standard photoshop save is LOWER than save for web..
but I'm not an expert ;-)
Comment 4 Roel 2015-03-27 09:44:00 UTC
Both files open OK on my Ubuntu system btw..
Comment 5 Halla Rempt 2015-04-09 08:18:25 UTC
Hm, I know I had trouble with the libjpeg on osx, and I'm guessing that that's the reason. I need to find a block of time to work on osx...
Comment 6 Roel 2015-04-09 08:27:00 UTC
Ah, thanks for explaining..

well.. about that block of time.. just forget about windows and concentrate on linux and osx I would suggest hahahaha.. just kidding..
Thanks for your effort and creating such a fine product!

Cheers!
Comment 7 Halla Rempt 2015-08-16 18:21:39 UTC
I've seen the crash now as well, the backtrace misses some stuff, though:


Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   libsystem_kernel.dylib        	0x00007fff8586d0c2 close + 10
1   libkdeui.5.dylib              	0x0000000107f34ce7 KCrash::defaultCrashHandler(int) + 247
2   libsystem_platform.dylib      	0x00007fff831975aa _sigtramp + 26
3   ???                           	0x0000000000000001 0 + 1
4   libkritaui.14.dylib           	0x00000001067149ce 0x106564000 + 1771982
5   libkritaui.14.dylib           	0x000000010670e17e 0x106564000 + 1745278
6   kritajpegimport.so            	0x0000000118dd2ad6 0x118dc7000 + 47830
7   kritajpegimport.so            	0x0000000118dd557b 0x118dc7000 + 58747
8   kritajpegimport.so            	0x0000000118dd088a 0x118dc7000 + 39050
9   libkritaui.14.dylib           	0x000000010687f2a0 0x106564000 + 3256992
10  libkritaui.14.dylib           	0x000000010687c816 KisFilterChain::invokeChain() + 406
11  libkritaui.14.dylib           	0x00000001068862e6 KisImportExportManager::importDocument(QString const&, QString const&, KisImportExportFilter::ConversionStatus&) + 2774
12  libkritaui.14.dylib           	0x000000010686398b KisDocument::openFile() + 2923
13  libkritaui.14.dylib           	0x00000001068714ec 0x106564000 + 3200236
14  libkritaui.14.dylib           	0x0000000106870049 0x106564000 + 3194953
15  libkritaui.14.dylib           	0x0000000106862d47 KisDocument::openUrlInternal(KUrl const&) + 375
16  libkritaui.14.dylib           	0x000000010686265f KisDocument::openUrl(KUrl const&) + 719
17  libkritaui.14.dylib           	0x000000010689a22a KisMainWindow::openDocumentInternal(KUrl const&, KisDocument*) + 170
18  libkritaui.14.dylib           	0x0000000106899f90 KisMainWindow::openDocument(KUrl const&) + 48
19  libkritaui.14.dylib           	0x000000010689e51f KisMainWindow::slotFileOpen() + 1071
20  libkritaui.14.dylib           	0x00000001068a4aed 0x106564000 + 3410669
21  QtCore                        	0x000000010916b48d QMetaObject::activate(QObject*, QMetaObject const*, int, void**) + 1693
22  QtGui                         	0x00000001082a9533 QAction::activate(QAction::ActionEvent) + 227
23  QtGui                         	0x0000000108261ef4 0x108229000 + 233204
24  com.apple.AppKit              	0x00007fff89cca260 -[NSApplication sendAction:to:from:] + 327
25  com.apple.AppKit              	0x00007fff89ce51c8 -[NSMenuItem _corePerformAction] + 394
26  com.apple.AppKit              	0x00007fff89ce4f04 -[NSCarbonMenuImpl performActionWithHighlightingForItemAtIndex:] + 117
27  com.apple.AppKit              	0x00007fff89ce407c -[NSMenu performKeyEquivalent:] + 289
28  com.apple.AppKit              	0x00007fff89ce08e1 -[NSApplication _handleKeyEquivalent:] + 822
29  com.apple.AppKit              	0x00007fff89c4facc -[NSApplication sendEvent:] + 3293
30  QtGui                         	0x000000010826235f 0x108229000 + 234335
31  com.apple.AppKit              	0x00007fff89a9f9f9 -[NSApplication run] + 646
32  QtGui                         	0x000000010826ade3 0x108229000 + 269795
33  QtCore                        	0x0000000109151b1d QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) + 477
34  QtCore                        	0x0000000109154d37 QCoreApplication::exec() + 199
35  org.krita                     	0x00000001062e3b10 main + 3072
36  libdyld.dylib                 	0x00007fff8df7d5fd start + 1
Comment 8 Halla Rempt 2015-09-20 12:54:27 UTC
*** Bug 348661 has been marked as a duplicate of this bug. ***
Comment 9 Halla Rempt 2016-01-24 09:05:56 UTC
This is fixed in 3.0 pre-alpha