Bug 345431 - should index and search user.xdg.comment
Summary: should index and search user.xdg.comment
Status: RESOLVED FIXED
Alias: None
Product: Baloo
Classification: Unmaintained
Component: General (show other bugs)
Version: 4.13
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Pinak Ahuja
URL:
Keywords:
: 340535 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-03-22 20:57 UTC by Richard Z.
Modified: 2018-05-19 19:59 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Z. 2015-03-22 20:57:32 UTC
On Fedora 21 I am unable to search by comments.

The comments were previously entered with Dolphin.

Reproducible: Always
Comment 1 Vishesh Handa 2015-03-23 14:09:17 UTC
I'm going to guess that you're on version 4.13 or 4.14. Please add that info from next time.

We have not enabled searching for comments by default. You'll have to type  `userComment:"some words"`. This however, will only work with Plasma 5.
Comment 2 Richard Z. 2015-03-23 20:33:00 UTC
Could it be enabled by default? Plasma5 or whatever.. but convenience wins.

It makes a huge difference in usability for jpeg files where comments are one of the very few ways to reasonably find stuff.
Comment 3 Vishesh Handa 2015-03-25 22:55:28 UTC
(In reply to Richard Z. from comment #2)
> Could it be enabled by default? Plasma5 or whatever.. but convenience wins.
> 
> It makes a huge difference in usability for jpeg files where comments are
> one of the very few ways to reasonably find stuff.

I'm slightly confused. It almost sounds like you're talking about the embedded exif comment wrt jpegs. Though even that isn't searched by default :/

I'm typically not too keen on making this a default as one looses context about search results, specially in places where you don't get to show much info about the file (krunner). In Dolphin you still kind of getting to see the comment if you look in the information panel, but it's not entirely obvious.

I like the idea of the user being able to easily understand why results have been shown and making the system as predictable as possible.
Comment 4 Richard Z. 2015-03-26 12:03:09 UTC
did not mean exif comments but those  entered with dolphin.

Imho those comments should have a high priority - if someone
enters the information manually he probably considers it pretty 
important.

Especially for picture files tags and comments are the only
practical search methods that I know so that kind of search
should be pretty easy.

How to do that exactly depends on the details of the GUI, dolphin
and other tools - if there are easy checkboxes like search 
comments/tags that would be fine.

Re making it clear why some results are shown - I also consider 
this important but don't think that restricting  the results returned 
will help that goal. 

Instead it might be interesting to investigate possibilities to
present the user additional information about how a particular
result was found.
Some ideas:
* return sub folders of search results (tag-hits, filename-hits,
  comment-hits, text-search-hits)
* find a way to display search result snippets
Comment 5 Vishesh Handa 2015-03-30 13:52:33 UTC
Perhaps we do want them searchable by default. Leaving this open for now.
Comment 6 Vishesh Handa 2015-04-09 10:27:01 UTC
*** Bug 340535 has been marked as a duplicate of this bug. ***
Comment 7 Nate Graham 2018-05-19 19:59:25 UTC
Comments are indexed now.