Bug 345029 - Roadmap to use model/view
Summary: Roadmap to use model/view
Status: REPORTED
Alias: None
Product: umbrello
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Other
: NOR wishlist
Target Milestone: ---
Assignee: Umbrello Development Group
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-10 21:55 UTC by Ralf Habacker
Modified: 2016-09-12 07:37 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ralf Habacker 2015-03-10 21:55:50 UTC
In the past the question has been raised from time to time if umbrello should be refactored to use more of the Qt model/view approach. This bug is for tracking this ongoing work.


Reproducible: Always
Comment 1 Ralf Habacker 2015-03-10 22:02:12 UTC
Emmanuel Lepage Vallée  wrote some related stuff at https://bugs.kde.org/show_bug.cgi?id=87104#c9
Comment 2 Ralf Habacker 2015-03-10 22:38:33 UTC
Bug 345031 has been opened for the evaluation of a few model/view classes implemented by Emmanuel.
Comment 3 Oliver Kellogg 2015-03-16 07:15:19 UTC
At https://bugs.kde.org/show_bug.cgi?id=87104#c5, Ralf Habacker wrote:
> (In reply to Oliver Kellogg from comment #4)
> > [...]
> > How would this class hierarchy view be different from the current tree view? 
> The recent tree view shows  a "package hierarchy" in the opposite to the
> derived and base classes , which would form the hierarchy.

Ah, I see.
I suppose the hierarchy would hinge on the generalization/realization associations among classes.
OTOH, generally I feel it unsatisfactory that Umbrello lacks a representation of the UMLAssociations in the list view.
See for example the Logical View at http://www.uwgb.edu/breznayp/cs372/rational.htm :
Rational Rose uses a simple line for (uni and bi directional) associations. Further, it uses a line with a solid arrow for generalization/realization, and a dashed line for dependency.
The advantage is that this includes not only generalization/realization but all UMLAssoication types.
The UMLAssociation can be manipulated in the tree view independent of diagrams, for example can be moved or deleted, or a double click could open a properties dialog for the association.
Perhaps I should open a separate wish for this?
Comment 4 Ralf Habacker 2015-03-17 22:48:47 UTC
(In reply to Oliver Kellogg from comment #3)
> At https://bugs.kde.org/show_bug.cgi?id=87104#c5, Ralf Habacker wrote:
> > (In reply to Oliver Kellogg from comment #4)
> > > [...]
> > > How would this class hierarchy view be different from the current tree view? 
> > The recent tree view shows  a "package hierarchy" in the opposite to the
> > derived and base classes , which would form the hierarchy.
> 
> Ah, I see.
> I suppose the hierarchy would hinge on the generalization/realization
> associations among classes.   

Looking into refactoringassistant.cpp shows, that the refactoring assistant is based on UMLAssociation instances, so there is no difference under the hood. 

> OTOH, generally I feel it unsatisfactory that Umbrello lacks a
> representation of the UMLAssociations in the list view.
> See for example the Logical View at
> http://www.uwgb.edu/breznayp/cs372/rational.htm :
> Rational Rose uses a simple line for (uni and bi directional) associations.
> Further, it uses a line with a solid arrow for generalization/realization,
> and a dashed line for dependency.
> The advantage is that this includes not only generalization/realization but
> all UMLAssoication types.
looks good.

> The UMLAssociation can be manipulated in the tree view independent of
> diagrams, for example can be moved or deleted, or a double click could open
> a properties dialog for the association.

which would also fix bug 332371 :-)

> Perhaps I should open a separate wish for this?

yes, will be good to track related commits.

There is still the question, if such an implementation would include refactoring the tree view to the model/view design pattern ?
Comment 5 Ralf Habacker 2015-03-18 12:20:13 UTC
With bug 73847  the recent tree view has been extended with a model/view based tree view showing stereotypes. The related git branch is here http://quickgit.kde.org/?p=umbrello.git&a=shortlog&h=43856d05914bd58c172702d84471408acafd6b24
Comment 6 Ralf Habacker 2016-09-12 07:35:26 UTC
With 2.17.2 (bug 345546) a model/view based dock window containing stereotypes has been added.
Comment 7 Ralf Habacker 2016-09-12 07:37:00 UTC
With 2.19.2 a model/view based dock window containing all diagrams has been added.