Bug 345003 - syntax highlighting for jsp incomplete
Summary: syntax highlighting for jsp incomplete
Status: RESOLVED FIXED
Alias: None
Product: frameworks-syntax-highlighting
Classification: Frameworks and Libraries
Component: syntax (other bugs)
Version First Reported In: unspecified
Platform: openSUSE Linux
: NOR wishlist
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2015-03-10 09:49 UTC by H.H.
Modified: 2019-08-22 17:37 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 5.62
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description H.H. 2015-03-10 09:49:26 UTC
kwrite/kate syntax highlighting doesn't recognize embedded <script> and <style> sections in jsp pages. it would be great, if such sections could be highlighted, too!

Reproducible: Always
Comment 1 H.H. 2015-07-20 09:12:02 UTC
perhaps I can help. what should I do, to add support for that?
Comment 2 Christoph Cullmann 2015-08-01 16:45:58 UTC
You could try to fixup the highlighting xml yourself, see

https://docs.kde.org/stable5/en/applications/katepart/highlight.html
Comment 3 Christoph Cullmann 2016-01-31 16:14:20 UTC
Hi,

if you want to have this, please read up on the link and provide some patch on

https://git.reviewboard.kde.org/dashboard/
Comment 4 Andrew Crouthamel 2018-09-25 21:51:09 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days, the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information.

For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please set the bug status as REPORTED so that the KDE team knows that the bug is ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 5 H.H. 2018-09-26 10:14:18 UTC
I had a look, but it seemed too complicated to me to fix that by myself.
Comment 6 Jonathan Poelen 2019-08-21 21:54:11 UTC
Git commit 433e5d85979ccf91224c930da80dfc8efd1d6342 by Jonathan Poelen.
Committed on 21/08/2019 at 22:07.
Pushed by jpoelen into branch 'master'.

JSP: support of <script> and <style> ; use IncludeRule ##Java

Summary: BUG: 345003

Reviewers: #framework_syntax_highlighting, dhaumann, cullmann

Reviewed By: #framework_syntax_highlighting, dhaumann

Subscribers: kwrite-devel, kde-frameworks-devel

Tags: #kate, #frameworks

Differential Revision: https://phabricator.kde.org/D23312

M  +19   -16   autotests/folding/highlight.jsp.fold
M  +66   -63   autotests/html/highlight.jsp.html
M  +4    -1    autotests/input/highlight.jsp
M  +54   -51   autotests/reference/highlight.jsp.ref
M  +38   -2854 data/syntax/jsp.xml

https://commits.kde.org/syntax-highlighting/433e5d85979ccf91224c930da80dfc8efd1d6342
Comment 7 H.H. 2019-08-22 10:26:35 UTC
Great, thanks!