Bug 344793 - thumbnail-preview broken for tags and timeline
Summary: thumbnail-preview broken for tags and timeline
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Thumbs-Image (show other bugs)
Version: 4.8.0
Platform: Kubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-03 18:36 UTC by Stephan Olbrich
Modified: 2015-03-09 21:47 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.9.0


Attachments
empty space where thumbnails should be (159.27 KB, image/jpeg)
2015-03-03 20:53 UTC, Stephan Olbrich
Details
blue album name bar disappeared (158.83 KB, image/jpeg)
2015-03-03 21:01 UTC, Stephan Olbrich
Details
imagealbumfiltermodel.patch (1.16 KB, patch)
2015-03-09 19:38 UTC, Maik Qualmann
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Olbrich 2015-03-03 18:36:07 UTC
If I browse my pictures using tags or the timeline, the thumbnail preview is often broken.
e.g. not all thumbnails are shown, empty space between thumbnails, thumbnails change to another picture when hovering with the mouse above them and changing back when scrolling, album-title bars which should separate images from different albums are drawn above thumbnails and sometimes disappear when scrolling.
If I switch to the table view all images are shown correctly.

Reproducible: Always
Comment 1 caulier.gilles 2015-03-03 19:34:31 UTC
Can you take some screenshots please ?

Gilles Caulier
Comment 2 Stephan Olbrich 2015-03-03 20:53:47 UTC
Created attachment 91395 [details]
empty space where thumbnails should be

I can't capture the more dynamic problems, but here you can see the empty space, where thumbnails should be.
Comment 3 Stephan Olbrich 2015-03-03 21:01:18 UTC
Created attachment 91396 [details]
blue album name bar disappeared

this is mostly the same image, than the one before, just scrolled a bit different and now the blue bar where the album name and date usually is, is now missing.
If I move the mouse to where the blue bar should be, it appears. If the mouse leaves the thumbnail part of the window, then it disappears again.
Comment 4 Maik Qualmann 2015-03-03 21:36:06 UTC
We had in January in Digikam-users a similar report. Does the error like this: https://www.youtube.com/watch?v=FaIYpzCxYO0&feature=youtu.be
From which camera model the pictures come from?

Maik
Comment 5 Stephan Olbrich 2015-03-03 21:57:26 UTC
yes it does look similar.
I just checked, when I enable subtree view for albums I get the same effects in the album view as well.
It seems this happens in all views which show thumbnails from multiple albums.

As in the video, if I switch to "Sort by name" for images everything works as expected. (I use sort by date as default)

The pictures come from several different cameras/brands even some smartphones, so I don't think this is related to a camera model.
Comment 6 Maik Qualmann 2015-03-03 22:21:04 UTC
Yes, sort by date is the trigger...

Maik
Comment 7 Maik Qualmann 2015-03-09 19:38:22 UTC
Created attachment 91512 [details]
imagealbumfiltermodel.patch

The following conditions must be met for this issue:
- Sort images by date
- Group images by album
- Timeline / Dates or album sub-tree enabled
- Albums in the sub-trees with the same date the images with older and newer date included

It can double album groups are generated that can not be distinguished.
Changes in digikamkcategorizedview.cpp would be no problem.
But I think we do not want a double album groups.

With this patch: If the album date is the same, the album path is used for sorting.
The group sort order is now used for the albums.
Comment 8 caulier.gilles 2015-03-09 21:36:07 UTC
Git commit 2eb92f515ebf764f8695accacdb2128f12061854 by Gilles Caulier.
Committed on 09/03/2015 at 21:32.
Pushed by cgilles into branch 'master'.

apply patch # 91512 from Maik Qualmann to fix album sorting if the album date is the same : the album path is used.
The group sort order is now used for the albums.
FIXED-IN: 4.9.0

M  +2    -2    NEWS
M  +3    -10   libs/models/imagealbumfiltermodel.cpp

http://commits.kde.org/digikam/2eb92f515ebf764f8695accacdb2128f12061854
Comment 9 caulier.gilles 2015-03-09 21:47:34 UTC
Git commit 3cfa54ed3525adacdc1fb640f3d30fe7941dbc8d by Gilles Caulier.
Committed on 09/03/2015 at 21:44.
Pushed by cgilles into branch 'frameworks'.

backport commit #2eb92f515ebf764f8695accacdb2128f12061854 from git/master to frameworks branch

M  +6    -13   libs/models/imagealbumfiltermodel.cpp

http://commits.kde.org/digikam/3cfa54ed3525adacdc1fb640f3d30fe7941dbc8d