Bug 344747 - libkomparediff2 floaty soversion
Summary: libkomparediff2 floaty soversion
Status: RESOLVED FIXED
Alias: None
Product: kompare
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Kompare developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-02 13:18 UTC by Harald Sitter
Modified: 2015-03-12 11:50 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Harald Sitter 2015-03-02 13:18:01 UTC
on git master

objdump -p /usr/lib/x86_64-linux-gnu/libkomparediff2.so |grep NAME                                                        
  SONAME               libkomparediff2.so.5.0

it would be very lovely if the SOVERSION attribute of set_target_properties could use the single digit SOVERSION defined for ecm_setup_version. Using a floaty SOVERSION is not very common and can screw over packagers who pay close attention to soversioning of libraries.


diff --git a/CMakeLists.txt b/CMakeLists.txt
index 3712a6f..9b12568 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -64,7 +64,7 @@ target_link_libraries(komparediff2
 target_include_directories(komparediff2 INTERFACE "$<INSTALL_INTERFACE:${INCLUDE_INSTALL_DIR}/libkomparediff2>")
 
 set_target_properties(komparediff2 PROPERTIES VERSION ${LIBKOMPAREDIFF2_VERSION_STRING}
-SOVERSION ${LIBKOMPAREDIFF2_VERSION_STRING} )
+SOVERSION 5)
 
 install(TARGETS komparediff2 EXPORT LibKompareDiff2Targets ${INSTALL_TARGETS_DEFAULT_ARGS})


Reproducible: Always
Comment 1 Kevin Kofler 2015-03-02 15:11:32 UTC
But there is no promise of binary compatibility between 5.n and 5.n+1 in a kdesdk library, is there? So keeping .so.5 would be misleading.
Comment 2 Aleix Pol 2015-03-02 15:15:49 UTC
Git commit 52f7fba38c4a5b5155f070cd0a48dd7e2149397d by Aleix Pol.
Committed on 02/03/2015 at 15:12.
Pushed by apol into branch 'frameworks'.

Fix how the so-version is specified on the library target.

M  +1    -2    CMakeLists.txt

http://commits.kde.org/libkomparediff2/52f7fba38c4a5b5155f070cd0a48dd7e2149397d
Comment 3 Harald Sitter 2015-03-11 13:29:23 UTC
Git commit e9b8500d4d527e9da8e2c69eaef4962f4d48e074 by Harald Sitter, on behalf of Aleix Pol.
Committed on 02/03/2015 at 15:12.
Pushed by sitter into branch 'master'.

Fix how the so-version is specified on the library target.

M  +1    -2    CMakeLists.txt

http://commits.kde.org/libkomparediff2/e9b8500d4d527e9da8e2c69eaef4962f4d48e074
Comment 4 Aleix Pol 2015-03-12 11:50:37 UTC
Git commit b3cfeb5511a935e3346ebd95a801055542a226d8 by Aleix Pol.
Committed on 02/03/2015 at 15:12.
Pushed by apol into branch 'Applications/15.04'.

Fix how the so-version is specified on the library target.

M  +1    -2    CMakeLists.txt

http://commits.kde.org/libkomparediff2/b3cfeb5511a935e3346ebd95a801055542a226d8