Bug 344533 - Vector layer duplication is broken (produces distorted paths)
Summary: Vector layer duplication is broken (produces distorted paths)
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Layer Stack (show other bugs)
Version: 2.9 Beta
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
: 358714 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-02-24 16:38 UTC by Aleks-Daniel Jakimenko
Modified: 2017-03-20 17:03 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
requested krita file (but does it have this bug?) (797.14 KB, application/x-krita)
2016-10-20 17:33 UTC, Aleks-Daniel Jakimenko
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Aleks-Daniel Jakimenko 2015-02-24 16:38:43 UTC
Duplicating a vector layer does not produce an exact copy.
Here is an original layer:
http://files.progarm.org/2015-02-24-183033_1276x761_scrot.png
And here is a duplicated layer:
http://files.progarm.org/2015-02-24-183046_1276x761_scrot.png

Switch between the images back and forth to see the difference.
Also, here are both layers, original layer is colored red:
http://files.progarm.org/2015-02-24-183132_1276x761_scrot.png

Wolthera on #krita suggested that it might be a rounding error. Indeed, the error is much worse in the bottom right corner:
http://files.progarm.org/2015-02-24-175430_532x523_scrot.png

Reproducible: Always

Steps to Reproduce:
1. Create a vector layer and draw some paths (polyline tool)
2. Duplicate it
3. Compare two layers
4. Huh?
Comment 1 Halla Rempt 2015-05-20 11:32:37 UTC
Hi Aleks,

Thanks for your report. I haven't been able to reproduce it myself yet, but if Wolthera can confirm it, it's confirmed. Would you be able to attach a .kra file with the broken duplicated vector layers so we can see what's inside?
Comment 2 Halla Rempt 2016-10-19 09:25:48 UTC
We still need a kra file that shows the issue.
Comment 3 Aleks-Daniel Jakimenko 2016-10-19 17:22:44 UTC
Unfortunately, I am unable to install krita currently.

However, I am surprised that it is so hard to reproduce it. It was one of the easiest bugs to reproduce. Perhaps something interesting is happening here? For example, at the time I was using 32-bit system, could that play any role in it?

But yeah, until problems with krita debian package are sorted out I can't help.
Comment 4 Halla Rempt 2016-10-20 14:25:00 UTC
Ah, you're the person who couldn't run the appimage on Debian?
Comment 5 Aleks-Daniel Jakimenko 2016-10-20 17:33:33 UTC
Created attachment 101668 [details]
requested krita file (but does it have this bug?)
Comment 6 Aleks-Daniel Jakimenko 2016-10-20 17:34:54 UTC
No. But good that you mentioned appimage!

OK, so I believe I was able to reproduce it. Interestingly, the results are not as dramatic as in my original report. Perhaps indeed the difference may exist between 32-bit and 64-bit builds? I don't know. Could've been different image size or something else.

But let's see. I created a vector image layer similar to the one in my original report. Then I duplicated it and changed the colors of these layers to be able to see the difference.

Now, the difference is not that big, but it is still there.

Here is a screenshot of the bottom right corner:
https://files.progarm.org/2016-10-20-202555_481x395_scrot.png

And here is a screenshot of top left corner:
https://files.progarm.org/2016-10-20-202637_740x585_scrot.png

So on bottom right it is clearly shifted, although not as much as on my original screenshots.

Now, I saved the file (you can see it attached), but if I reopen it I see this:
https://files.progarm.org/2016-10-20-203353_671x548_scrot.png

Sooo… where did the bug go? It feels like it is still there on Y axis, but not on X… weird.

Does it help?
Comment 7 Halla Rempt 2016-10-24 07:56:42 UTC
Yes, strange... Could you share the .kra file with us?
Comment 8 Aleks-Daniel Jakimenko 2016-10-24 11:35:23 UTC
It is already attached.

But as I said, I'm not sure if it is going to be visible in the .kra file. Are there any problems reproducing it?
Comment 9 Halla Rempt 2016-10-24 11:45:00 UTC
Ah, I missed that, sorry.
Comment 10 Halla Rempt 2016-10-24 12:17:44 UTC
Ah, I missed that, sorry. Yes, with that file I can see the effect you mean.
Comment 11 Halla Rempt 2016-11-03 14:15:57 UTC
*** Bug 358714 has been marked as a duplicate of this bug. ***
Comment 12 Halla Rempt 2016-11-03 14:16:21 UTC
Note that we will be replacing the current odg implementation with svg, which means all of this code will be gone.
Comment 13 Dmitry Kazakov 2017-03-20 16:59:59 UTC
In the current version of my Vector branch, filling of the shapes in not supported. So i'll mark this bug as "later" so we could check when the patterns thing will be implemented properly.
Comment 14 Dmitry Kazakov 2017-03-20 17:03:45 UTC
Ouch, I commented in a wrong bug. This bug is actually fixed in my branch :)