Bug 344497 - Suggest that the user should open a database in order to be able to import search results
Summary: Suggest that the user should open a database in order to be able to import se...
Status: RESOLVED FIXED
Alias: None
Product: KBibTeX
Classification: Applications
Component: Network/online search (show other bugs)
Version: git (master)
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: ---
Assignee: Thomas Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-23 18:12 UTC by Arseniy Lartsev
Modified: 2015-03-07 17:38 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
How to tell the user that no database is open (120.25 KB, image/png)
2015-02-23 18:12 UTC, Arseniy Lartsev
Details
Possible implementation of telling the user that no database is open (1.66 KB, patch)
2015-02-23 18:16 UTC, Arseniy Lartsev
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Arseniy Lartsev 2015-02-23 18:12:26 UTC
Created attachment 91250 [details]
How to tell the user that no database is open

A small improvement related to https://bugs.kde.org/show_bug.cgi?id=344495

When the program has just started, there's no database open, but that could be unclear to the user. As a result, the user could fail to understand why they can't import search results. I, for one, would probably end up diving into the source code to figure out why the import button is disabled (except it wasn't disabled due to the abovementioned bug).

Therefore I'd like to suggest that the program should somehow make it explicitly obvious to the user that no database is open, hence importing search results is impossible. Attached is one possible imprementation of this.
Comment 1 Arseniy Lartsev 2015-02-23 18:16:16 UTC
Created attachment 91251 [details]
Possible implementation of telling the user that no database is open
Comment 2 Thomas Fischer 2015-03-07 17:37:40 UTC
Git commit 398f121423c304614bdea65501e053943ac43a4f by Thomas Fischer.
Committed on 07/03/2015 at 17:33.
Pushed by thomasfischer into branch 'kbibtex/0.5'.

Message next to Import button in Search Results

As suggested in bug report 344497, an inline message
(an icon and a label) is shown next to the Import
button in the Search Results docklet if this button
is disabled.
There are two reasons, why the button may be disabled:
1. No results to import.
2. No bibliography open to import to.

Patch 91251 provided by Arseniy Lartsev (original bug
reporter) did only cover case 2, so it had to be
rewritten and expanded.

M  +1    -0    src/program/docklets/elementform.cpp
M  +37   -1    src/program/docklets/searchresults.cpp

http://commits.kde.org/kbibtex/398f121423c304614bdea65501e053943ac43a4f
Comment 3 Thomas Fischer 2015-03-07 17:38:34 UTC
Git commit bc318075aec7af4661eb624a1eb77ae21296d3c3 by Thomas Fischer.
Committed on 07/03/2015 at 17:33.
Pushed by thomasfischer into branch 'kbibtex/0.6'.

Message next to Import button in Search Results

As suggested in bug report 344497, an inline message
(an icon and a label) is shown next to the Import
button in the Search Results docklet if this button
is disabled.
There are two reasons, why the button may be disabled:
1. No results to import.
2. No bibliography open to import to.

Patch 91251 provided by Arseniy Lartsev (original bug
reporter) did only cover case 2, so it had to be
rewritten and expanded.

M  +1    -0    src/program/docklets/elementform.cpp
M  +37   -1    src/program/docklets/searchresults.cpp

http://commits.kde.org/kbibtex/bc318075aec7af4661eb624a1eb77ae21296d3c3
Comment 4 Thomas Fischer 2015-03-07 17:38:47 UTC
Git commit 70f6b0306f5e99bfe2bcaef6add3dfea93fc8be3 by Thomas Fischer.
Committed on 07/03/2015 at 17:33.
Pushed by thomasfischer into branch 'master'.

Message next to Import button in Search Results

As suggested in bug report 344497, an inline message
(an icon and a label) is shown next to the Import
button in the Search Results docklet if this button
is disabled.
There are two reasons, why the button may be disabled:
1. No results to import.
2. No bibliography open to import to.

Patch 91251 provided by Arseniy Lartsev (original bug
reporter) did only cover case 2, so it had to be
rewritten and expanded.

M  +1    -0    src/program/docklets/elementform.cpp
M  +37   -1    src/program/docklets/searchresults.cpp

http://commits.kde.org/kbibtex/70f6b0306f5e99bfe2bcaef6add3dfea93fc8be3